[ 
https://issues.apache.org/jira/browse/HIVE-27158?focusedWorklogId=853106&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-853106
 ]

ASF GitHub Bot logged work on HIVE-27158:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Mar/23 09:07
            Start Date: 27/Mar/23 09:07
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #4131:
URL: https://github.com/apache/hive/pull/4131#discussion_r1148989152


##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -2207,6 +2207,8 @@ public static enum ConfVars {
         "Whether to use codec pool in ORC. Disable if there are bugs with 
codec reuse."),
     HIVE_USE_STATS_FROM("hive.use.stats.from","iceberg","Use stats from 
iceberg table snapshot for query " +
         "planning. This has three values metastore, puffin and iceberg"),
+    HIVE_COL_STATS_SOURCE("hive.col.stats.source","metastore","Use stats from 
puffin file for  query " +

Review Comment:
   - do we support `iceberg` mode? 
   - please update the description - "Use stats from the selected source for 
query planning" 
   
   what's the difference between `HIVE_USE_STATS_FROM` && 
`HIVE_COL_STATS_SOURCE `? it doesn't seem to be a generic config, should we add 
an ICEBERG prefix?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 853106)
    Time Spent: 3h 20m  (was: 3h 10m)

> Store hive columns stats in puffin files for iceberg tables
> -----------------------------------------------------------
>
>                 Key: HIVE-27158
>                 URL: https://issues.apache.org/jira/browse/HIVE-27158
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Simhadri Govindappa
>            Assignee: Simhadri Govindappa
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to