[ 
https://issues.apache.org/jira/browse/HIVE-27101?focusedWorklogId=850586&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-850586
 ]

ASF GitHub Bot logged work on HIVE-27101:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Mar/23 09:21
            Start Date: 13/Mar/23 09:21
    Worklog Time Spent: 10m 
      Work Description: kasakrisz commented on code in PR #4079:
URL: https://github.com/apache/hive/pull/4079#discussion_r1133640784


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveMaterializedViewUtils.java:
##########
@@ -277,6 +276,20 @@ public void visit(RelNode node, int ordinal, RelNode 
parent) {
             materialization.getAst());
   }
 
+  private static HiveRelOptMaterialization 
augmentMaterializationWithTimeInformation(

Review Comment:
   This method is part of the
   ```
   public static HiveRelOptMaterialization 
augmentMaterializationWithTimeInformation(
         HiveRelOptMaterialization materialization, String validTxnsList,
         MaterializationSnapshot snapshot) throws LockException
   ```
   method.
   These utility methods construct a rule parameterize it with the saved 
Materialized view creation metadata and apply it to the MV query plan.
   I refactored these to extract common parts and make it more readable.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 850586)
    Time Spent: 8h  (was: 7h 50m)

> Support incremental materialized view rebuild when Iceberg source tables have 
> insert operation only.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-27101
>                 URL: https://issues.apache.org/jira/browse/HIVE-27101
>             Project: Hive
>          Issue Type: Improvement
>          Components: Iceberg integration, Materialized views
>            Reporter: Krisztian Kasa
>            Assignee: Krisztian Kasa
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 8h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to