[ https://issues.apache.org/jira/browse/HIVE-27017?focusedWorklogId=843744&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843744 ]
ASF GitHub Bot logged work on HIVE-27017: ----------------------------------------- Author: ASF GitHub Bot Created on: 06/Feb/23 08:45 Start Date: 06/Feb/23 08:45 Worklog Time Spent: 10m Work Description: kasakrisz commented on PR #4014: URL: https://github.com/apache/hive/pull/4014#issuecomment-1418713588 @yigress Your patch looks good to me but I have some comments: 1. Could you please check if the 26 failing test caused by this patch? 2. Have you tested whether the table is dropped in case of any error while executing the query in the ctas statement or cancelled by the user? In case of Iceberg it is handled by [HiveIcebergQueryLifeTimeHook]( https://github.com/apache/hive/blob/513127dd7793bee5caccbd266aa81d6bf6299902/iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergQueryLifeTimeHook.java#L60) and set via ``` set hive.query.lifetime.hooks=org.apache.iceberg.mr.hive.HiveIcebergQueryLifeTimeHook; ``` Issue Time Tracking ------------------- Worklog Id: (was: 843744) Time Spent: 0.5h (was: 20m) > option to use createTable DDLTask in CTAS for StorgeHandler > ----------------------------------------------------------- > > Key: HIVE-27017 > URL: https://issues.apache.org/jira/browse/HIVE-27017 > Project: Hive > Issue Type: Improvement > Components: StorageHandler > Affects Versions: 3.1.3 > Reporter: Yi Zhang > Assignee: Yi Zhang > Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > This is to add a directInsert option for StorageHandler and advance DDLTask > for CTAS when it is storagehandler directInsert mode. This is partial > backport of HIVE-26771 -- This message was sent by Atlassian Jira (v8.20.10#820010)