[ https://issues.apache.org/jira/browse/HIVE-27000?focusedWorklogId=843642&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843642 ]
ASF GitHub Bot logged work on HIVE-27000: ----------------------------------------- Author: ASF GitHub Bot Created on: 04/Feb/23 21:30 Start Date: 04/Feb/23 21:30 Worklog Time Spent: 10m Work Description: asolimando commented on PR #3997: URL: https://github.com/apache/hive/pull/3997#issuecomment-1416854474 > And I messed up while committing :-( Forgot to mention Akshat's name while committing, Have reverted this and committed it again with the correct message. I don't have anything more than sorry here, will be more careful next time We never make mistakes only if we do nothing at all, you are very very active so it happens. On that note, thanks a lot for always helping out with reviews and merges, much appreciated Ayush! Issue Time Tracking ------------------- Worklog Id: (was: 843642) Time Spent: 2h 20m (was: 2h 10m) > Improve the modularity of the *ColumnStatsMerger classes > -------------------------------------------------------- > > Key: HIVE-27000 > URL: https://issues.apache.org/jira/browse/HIVE-27000 > Project: Hive > Issue Type: Improvement > Components: Statistics > Affects Versions: 4.0.0-alpha-2 > Reporter: Alessandro Solimando > Assignee: Alessandro Solimando > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > *ColumnStatsMerger classes contain a lot of duplicate code which is not > specific to the data type, and that could therefore be lifted to a common > parent class. > This phenomenon is bound to become even worse if we keep enriching further > our supported set of statistics as we did in the context of HIVE-26221. > The current ticket aims at improving the modularity and code reuse of the > *ColumnStatsMerger classes, while improving unit-test coverage to cover all > classes and support more use-cases. -- This message was sent by Atlassian Jira (v8.20.10#820010)