[
https://issues.apache.org/jira/browse/HIVE-26537?focusedWorklogId=843363&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-843363
]
ASF GitHub Bot logged work on HIVE-26537:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/23 03:24
Start Date: 03/Feb/23 03:24
Worklog Time Spent: 10m
Work Description: nrg4878 commented on code in PR #3599:
URL: https://github.com/apache/hive/pull/3599#discussion_r1095313330
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -939,6 +940,16 @@ struct DropPartitionsRequest {
9: optional string catName
}
+struct DropPartitionRequest {
+ 1: optional string dbName,
+ 2: optional string tblName,
+ 3: optional string partName,
+ 4: optional list<string> partVals,
+ 5: optional bool deleteData,
+ 6: optional EnvironmentContext environmentContext,
+ 7: optional string catName
Review Comment:
should the catName be the first in this struct? just looks cleaner. I know
it was added much later than the others for some of the other structs. But we
are adding a new one.
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2070,18 +2096,30 @@ struct CreateDatabaseRequest {
8: optional string catalogName,
9: optional i32 createTime,
10: optional string managedLocationUri,
- 11: optional string type,
- 12: optional string dataConnectorName
+ 11: optional DatabaseType type,
+ 12: optional string dataConnectorName,
+ 13: optional string remote_dbname
Review Comment:
why do we need the remote_dbname in this? this will be provided in the
parameters along with the createDB request.
Also, I am a bit concerned about changing type from string to DatabaseType.
its cleaner but is there another benefit?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -1696,13 +1707,28 @@ struct ExtendedTableInfo {
4: optional list<string> requiredWriteCapabilities // capabilities required
for write access
}
+struct DropTableRequest {
+ 1: required string dbName,
+ 2: required string tableName,
+ 3: optional string catalogName,
Review Comment:
same here. It could make sense for catalogName to be the first.
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2070,18 +2096,30 @@ struct CreateDatabaseRequest {
8: optional string catalogName,
9: optional i32 createTime,
10: optional string managedLocationUri,
- 11: optional string type,
- 12: optional string dataConnectorName
+ 11: optional DatabaseType type,
+ 12: optional string dataConnectorName,
+ 13: optional string remote_dbname
}
struct CreateDataConnectorRequest {
- 1: DataConnector connector
+ 1: required DataConnector connector
}
struct GetDataConnectorRequest {
1: required string connectorName
}
+struct AlterDataConnectorRequest {
+ 1: required string connectorName,
+ 2: required DataConnector newConnector
+}
+
+struct DropDataConnectorRequest {
+ 1: required string connectorName,
+ 2: optional bool ifNotExists,
+ 3: optional bool checkReferences
Review Comment:
Do we need this? This causes HMS to look at all the DBs that reference this
connector name right? instead should we just define what should happen? We
could allow the connector be dropped even with references (under the assumption
that they want to re-create it differently, eg different properties like
password, maybe secure the credentials etc) or do not allow dropping of the
connector if there are references.
If we have this, I think clients can define the behavior or keep changing it
on the long run, but I am worried about having to scan all DBs.
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2236,9 +2282,9 @@ struct GetSchemaResponse {
struct GetPartitionRequest {
1: optional string catName,
- 2: required string dbName,
- 3: required string tblName,
- 4: required list<string> partVals,
+ 2: optional string dbName,
Review Comment:
why are these fields changed to optional? Shouldn't this request always be
scoped to a table?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2249,8 +2295,8 @@ struct GetPartitionResponse {
struct PartitionsRequest { // Not using Get prefix as that name is already
used for a different method
1: optional string catName,
- 2: required string dbName,
- 3: required string tblName,
+ 2: optional string dbName,
Review Comment:
same comment as above
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2262,8 +2308,8 @@ struct PartitionsResponse { // Not using Get prefix as
that name is already used
struct GetPartitionNamesPsRequest {
1: optional string catName,
- 2: required string dbName,
- 3: required string tblName,
+ 2: optional string dbName,
Review Comment:
ditto
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2451,19 +2497,24 @@ service ThriftHiveMetastore extends
fb303.FacebookService
void drop_catalog(1: DropCatalogRequest catName) throws
(1:NoSuchObjectException o1, 2:InvalidOperationException o2, 3:MetaException o3)
void create_database(1:Database database) throws(1:AlreadyExistsException
o1, 2:InvalidObjectException o2, 3:MetaException o3)
Review Comment:
shouldn't this be deleted?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2451,19 +2497,24 @@ service ThriftHiveMetastore extends
fb303.FacebookService
void drop_catalog(1: DropCatalogRequest catName) throws
(1:NoSuchObjectException o1, 2:InvalidOperationException o2, 3:MetaException o3)
void create_database(1:Database database) throws(1:AlreadyExistsException
o1, 2:InvalidObjectException o2, 3:MetaException o3)
+ void create_database_req(1:CreateDatabaseRequest createDatabaseRequest)
throws(1:AlreadyExistsException o1, 2:InvalidObjectException o2,
3:MetaException o3)
Database get_database(1:string name) throws(1:NoSuchObjectException o1,
2:MetaException o2)
Database get_database_req(1:GetDatabaseRequest request)
throws(1:NoSuchObjectException o1, 2:MetaException o2)
void drop_database(1:string name, 2:bool deleteData, 3:bool cascade)
throws(1:NoSuchObjectException o1, 2:InvalidOperationException o2,
3:MetaException o3)
void drop_database_req(1:DropDatabaseRequest req)
throws(1:NoSuchObjectException o1, 2:InvalidOperationException o2,
3:MetaException o3)
list<string> get_databases(1:string pattern) throws(1:MetaException o1)
list<string> get_all_databases() throws(1:MetaException o1)
void alter_database(1:string dbname, 2:Database db) throws(1:MetaException
o1, 2:NoSuchObjectException o2)
+ void alter_database_req(1:AlterDatabaseRequest alterDbReq)
throws(1:MetaException o1, 2:NoSuchObjectException o2)
void create_dataconnector(1:DataConnector connector)
throws(1:AlreadyExistsException o1, 2:InvalidObjectException o2,
3:MetaException o3)
Review Comment:
shouldn't this be deleted?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2451,19 +2497,24 @@ service ThriftHiveMetastore extends
fb303.FacebookService
void drop_catalog(1: DropCatalogRequest catName) throws
(1:NoSuchObjectException o1, 2:InvalidOperationException o2, 3:MetaException o3)
void create_database(1:Database database) throws(1:AlreadyExistsException
o1, 2:InvalidObjectException o2, 3:MetaException o3)
+ void create_database_req(1:CreateDatabaseRequest createDatabaseRequest)
throws(1:AlreadyExistsException o1, 2:InvalidObjectException o2,
3:MetaException o3)
Database get_database(1:string name) throws(1:NoSuchObjectException o1,
2:MetaException o2)
Database get_database_req(1:GetDatabaseRequest request)
throws(1:NoSuchObjectException o1, 2:MetaException o2)
void drop_database(1:string name, 2:bool deleteData, 3:bool cascade)
throws(1:NoSuchObjectException o1, 2:InvalidOperationException o2,
3:MetaException o3)
void drop_database_req(1:DropDatabaseRequest req)
throws(1:NoSuchObjectException o1, 2:InvalidOperationException o2,
3:MetaException o3)
list<string> get_databases(1:string pattern) throws(1:MetaException o1)
list<string> get_all_databases() throws(1:MetaException o1)
void alter_database(1:string dbname, 2:Database db) throws(1:MetaException
o1, 2:NoSuchObjectException o2)
Review Comment:
shouldn't this be deleted?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2451,19 +2497,24 @@ service ThriftHiveMetastore extends
fb303.FacebookService
void drop_catalog(1: DropCatalogRequest catName) throws
(1:NoSuchObjectException o1, 2:InvalidOperationException o2, 3:MetaException o3)
void create_database(1:Database database) throws(1:AlreadyExistsException
o1, 2:InvalidObjectException o2, 3:MetaException o3)
+ void create_database_req(1:CreateDatabaseRequest createDatabaseRequest)
throws(1:AlreadyExistsException o1, 2:InvalidObjectException o2,
3:MetaException o3)
Database get_database(1:string name) throws(1:NoSuchObjectException o1,
2:MetaException o2)
Database get_database_req(1:GetDatabaseRequest request)
throws(1:NoSuchObjectException o1, 2:MetaException o2)
void drop_database(1:string name, 2:bool deleteData, 3:bool cascade)
throws(1:NoSuchObjectException o1, 2:InvalidOperationException o2,
3:MetaException o3)
void drop_database_req(1:DropDatabaseRequest req)
throws(1:NoSuchObjectException o1, 2:InvalidOperationException o2,
3:MetaException o3)
list<string> get_databases(1:string pattern) throws(1:MetaException o1)
list<string> get_all_databases() throws(1:MetaException o1)
void alter_database(1:string dbname, 2:Database db) throws(1:MetaException
o1, 2:NoSuchObjectException o2)
+ void alter_database_req(1:AlterDatabaseRequest alterDbReq)
throws(1:MetaException o1, 2:NoSuchObjectException o2)
void create_dataconnector(1:DataConnector connector)
throws(1:AlreadyExistsException o1, 2:InvalidObjectException o2,
3:MetaException o3)
+ void create_dataconnector_req(1:CreateDataConnectorRequest connectorReq)
throws(1:AlreadyExistsException o1, 2:InvalidObjectException o2,
3:MetaException o3)
DataConnector get_dataconnector_req(1:GetDataConnectorRequest request)
throws(1:NoSuchObjectException o1, 2:MetaException o2)
- void drop_dataconnector(1:string name, bool ifNotExists, bool
checkReferences) throws(1:NoSuchObjectException o1, 2:InvalidOperationException
o2, 3:MetaException o3)
+ void drop_dataconnector(1:string name, 2:bool ifNotExists, 3:bool
checkReferences) throws(1:NoSuchObjectException o1, 2:InvalidOperationException
o2, 3:MetaException o3)
+ void drop_dataconnector_req(1:DropDataConnectorRequest dropDcReq)
throws(1:NoSuchObjectException o1, 2:InvalidOperationException o2,
3:MetaException o3)
list<string> get_dataconnectors() throws(1:MetaException o1)
void alter_dataconnector(1:string name, 2:DataConnector connector)
throws(1:MetaException o1, 2:NoSuchObjectException o2)
Review Comment:
shouldnt this be deleted?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2451,19 +2497,24 @@ service ThriftHiveMetastore extends
fb303.FacebookService
void drop_catalog(1: DropCatalogRequest catName) throws
(1:NoSuchObjectException o1, 2:InvalidOperationException o2, 3:MetaException o3)
void create_database(1:Database database) throws(1:AlreadyExistsException
o1, 2:InvalidObjectException o2, 3:MetaException o3)
+ void create_database_req(1:CreateDatabaseRequest createDatabaseRequest)
throws(1:AlreadyExistsException o1, 2:InvalidObjectException o2,
3:MetaException o3)
Database get_database(1:string name) throws(1:NoSuchObjectException o1,
2:MetaException o2)
Database get_database_req(1:GetDatabaseRequest request)
throws(1:NoSuchObjectException o1, 2:MetaException o2)
void drop_database(1:string name, 2:bool deleteData, 3:bool cascade)
throws(1:NoSuchObjectException o1, 2:InvalidOperationException o2,
3:MetaException o3)
void drop_database_req(1:DropDatabaseRequest req)
throws(1:NoSuchObjectException o1, 2:InvalidOperationException o2,
3:MetaException o3)
list<string> get_databases(1:string pattern) throws(1:MetaException o1)
list<string> get_all_databases() throws(1:MetaException o1)
void alter_database(1:string dbname, 2:Database db) throws(1:MetaException
o1, 2:NoSuchObjectException o2)
+ void alter_database_req(1:AlterDatabaseRequest alterDbReq)
throws(1:MetaException o1, 2:NoSuchObjectException o2)
void create_dataconnector(1:DataConnector connector)
throws(1:AlreadyExistsException o1, 2:InvalidObjectException o2,
3:MetaException o3)
+ void create_dataconnector_req(1:CreateDataConnectorRequest connectorReq)
throws(1:AlreadyExistsException o1, 2:InvalidObjectException o2,
3:MetaException o3)
DataConnector get_dataconnector_req(1:GetDataConnectorRequest request)
throws(1:NoSuchObjectException o1, 2:MetaException o2)
- void drop_dataconnector(1:string name, bool ifNotExists, bool
checkReferences) throws(1:NoSuchObjectException o1, 2:InvalidOperationException
o2, 3:MetaException o3)
+ void drop_dataconnector(1:string name, 2:bool ifNotExists, 3:bool
checkReferences) throws(1:NoSuchObjectException o1, 2:InvalidOperationException
o2, 3:MetaException o3)
Review Comment:
shouldnt this be deleted?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2533,6 +2584,8 @@ service ThriftHiveMetastore extends fb303.FacebookService
void drop_table_with_environment_context(1:string dbname, 2:string name,
3:bool deleteData,
Review Comment:
shouldnt this be deleted?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2533,6 +2584,8 @@ service ThriftHiveMetastore extends fb303.FacebookService
void drop_table_with_environment_context(1:string dbname, 2:string name,
3:bool deleteData,
4:EnvironmentContext environment_context)
throws(1:NoSuchObjectException o1, 2:MetaException o3)
+ void drop_table_req(1:DropTableRequest dropTableReq)
+ throws(1:NoSuchObjectException o1, 2:MetaException o3)
void truncate_table(1:string dbName, 2:string tableName, 3:list<string>
partNames)
Review Comment:
should we convert this to a request based as well?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2627,21 +2682,29 @@ service ThriftHiveMetastore extends
fb303.FacebookService
Partition append_partition_with_environment_context(1:string db_name,
2:string tbl_name,
3:list<string> part_vals, 4:EnvironmentContext environment_context)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
+ Partition append_partition_req(1:AppendPartitionsRequest appendPartitionsReq)
+ throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
Partition append_partition_by_name(1:string db_name, 2:string tbl_name,
3:string part_name)
Review Comment:
shouldnt this be deleted?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2627,21 +2682,29 @@ service ThriftHiveMetastore extends
fb303.FacebookService
Partition append_partition_with_environment_context(1:string db_name,
2:string tbl_name,
3:list<string> part_vals, 4:EnvironmentContext environment_context)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
+ Partition append_partition_req(1:AppendPartitionsRequest appendPartitionsReq)
+ throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
Partition append_partition_by_name(1:string db_name, 2:string tbl_name,
3:string part_name)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
Partition append_partition_by_name_with_environment_context(1:string
db_name, 2:string tbl_name,
Review Comment:
shouldnt this be deleted?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2627,21 +2682,29 @@ service ThriftHiveMetastore extends
fb303.FacebookService
Partition append_partition_with_environment_context(1:string db_name,
2:string tbl_name,
3:list<string> part_vals, 4:EnvironmentContext environment_context)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
+ Partition append_partition_req(1:AppendPartitionsRequest appendPartitionsReq)
+ throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
Partition append_partition_by_name(1:string db_name, 2:string tbl_name,
3:string part_name)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
Partition append_partition_by_name_with_environment_context(1:string
db_name, 2:string tbl_name,
3:string part_name, 4:EnvironmentContext environment_context)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
+ Partition append_partition_by_name_req(1:AppendPartitionsRequest
appendPartitionRequest)
+ throws (1:InvalidObjectException o1, 2:AlreadyExistsException o2,
3:MetaException o3)
bool drop_partition(1:string db_name, 2:string tbl_name, 3:list<string>
part_vals, 4:bool deleteData)
throws(1:NoSuchObjectException o1, 2:MetaException o2)
bool drop_partition_with_environment_context(1:string db_name, 2:string
tbl_name,
Review Comment:
shouldnt this be deleted?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2627,21 +2682,29 @@ service ThriftHiveMetastore extends
fb303.FacebookService
Partition append_partition_with_environment_context(1:string db_name,
2:string tbl_name,
3:list<string> part_vals, 4:EnvironmentContext environment_context)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
+ Partition append_partition_req(1:AppendPartitionsRequest appendPartitionsReq)
+ throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
Partition append_partition_by_name(1:string db_name, 2:string tbl_name,
3:string part_name)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
Partition append_partition_by_name_with_environment_context(1:string
db_name, 2:string tbl_name,
3:string part_name, 4:EnvironmentContext environment_context)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
+ Partition append_partition_by_name_req(1:AppendPartitionsRequest
appendPartitionRequest)
+ throws (1:InvalidObjectException o1, 2:AlreadyExistsException o2,
3:MetaException o3)
bool drop_partition(1:string db_name, 2:string tbl_name, 3:list<string>
part_vals, 4:bool deleteData)
throws(1:NoSuchObjectException o1, 2:MetaException o2)
bool drop_partition_with_environment_context(1:string db_name, 2:string
tbl_name,
3:list<string> part_vals, 4:bool deleteData, 5:EnvironmentContext
environment_context)
throws(1:NoSuchObjectException o1, 2:MetaException o2)
+ bool drop_partition_req(1:DropPartitionRequest dropPartitionReq)
+ throws(1:NoSuchObjectException o1, 2:MetaException o2)
bool drop_partition_by_name(1:string db_name, 2:string tbl_name, 3:string
part_name, 4:bool deleteData)
Review Comment:
shouldnt this be deleted?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2679,7 +2742,8 @@ PartitionsResponse get_partitions_req(1:PartitionsRequest
req)
list<string> get_partition_names(1:string db_name, 2:string tbl_name, 3:i16
max_parts=-1)
Review Comment:
shouldnt this be deleted?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2276,8 +2322,8 @@ struct GetPartitionNamesPsResponse {
struct GetPartitionsPsWithAuthRequest {
1: optional string catName,
- 2: required string dbName,
- 3: required string tblName,
+ 2: optional string dbName,
Review Comment:
ditto
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2060,7 +2086,7 @@ struct CreateTableRequest {
}
struct CreateDatabaseRequest {
- 1: required string databaseName,
+ 1: optional string databaseName,
Review Comment:
not sure I understand this. Should the dbName for a createDB API be required?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2627,21 +2682,29 @@ service ThriftHiveMetastore extends
fb303.FacebookService
Partition append_partition_with_environment_context(1:string db_name,
2:string tbl_name,
3:list<string> part_vals, 4:EnvironmentContext environment_context)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
+ Partition append_partition_req(1:AppendPartitionsRequest appendPartitionsReq)
+ throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
Partition append_partition_by_name(1:string db_name, 2:string tbl_name,
3:string part_name)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
Partition append_partition_by_name_with_environment_context(1:string
db_name, 2:string tbl_name,
3:string part_name, 4:EnvironmentContext environment_context)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
+ Partition append_partition_by_name_req(1:AppendPartitionsRequest
appendPartitionRequest)
+ throws (1:InvalidObjectException o1, 2:AlreadyExistsException o2,
3:MetaException o3)
bool drop_partition(1:string db_name, 2:string tbl_name, 3:list<string>
part_vals, 4:bool deleteData)
Review Comment:
shouldnt this be deleted?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2627,21 +2682,29 @@ service ThriftHiveMetastore extends
fb303.FacebookService
Partition append_partition_with_environment_context(1:string db_name,
2:string tbl_name,
3:list<string> part_vals, 4:EnvironmentContext environment_context)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
+ Partition append_partition_req(1:AppendPartitionsRequest appendPartitionsReq)
+ throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
Partition append_partition_by_name(1:string db_name, 2:string tbl_name,
3:string part_name)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
Partition append_partition_by_name_with_environment_context(1:string
db_name, 2:string tbl_name,
3:string part_name, 4:EnvironmentContext environment_context)
throws (1:InvalidObjectException o1,
2:AlreadyExistsException o2, 3:MetaException o3)
+ Partition append_partition_by_name_req(1:AppendPartitionsRequest
appendPartitionRequest)
+ throws (1:InvalidObjectException o1, 2:AlreadyExistsException o2,
3:MetaException o3)
bool drop_partition(1:string db_name, 2:string tbl_name, 3:list<string>
part_vals, 4:bool deleteData)
throws(1:NoSuchObjectException o1, 2:MetaException o2)
bool drop_partition_with_environment_context(1:string db_name, 2:string
tbl_name,
3:list<string> part_vals, 4:bool deleteData, 5:EnvironmentContext
environment_context)
throws(1:NoSuchObjectException o1, 2:MetaException o2)
+ bool drop_partition_req(1:DropPartitionRequest dropPartitionReq)
+ throws(1:NoSuchObjectException o1, 2:MetaException o2)
bool drop_partition_by_name(1:string db_name, 2:string tbl_name, 3:string
part_name, 4:bool deleteData)
throws(1:NoSuchObjectException o1, 2:MetaException o2)
bool drop_partition_by_name_with_environment_context(1:string db_name,
2:string tbl_name,
Review Comment:
shouldnt this be deleted?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2616,6 +2669,8 @@ service ThriftHiveMetastore extends fb303.FacebookService
2:EnvironmentContext environment_context)
throws (1:InvalidObjectException o1, 2:AlreadyExistsException o2,
3:MetaException o3)
+ Partition add_partition_req(1:AddPartitionsRequest addPartitionsReq)
+ throws (1:InvalidObjectException o1, 2:AlreadyExistsException o2,
3:MetaException o3)
i32 add_partitions(1:list<Partition> new_parts)
Review Comment:
shouldnt this be deleted?
##########
standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift:
##########
@@ -2627,21 +2682,29 @@ service ThriftHiveMetastore extends
fb303.FacebookService
Partition append_partition_with_environment_context(1:string db_name,
2:string tbl_name,
Review Comment:
shouldnt this be deleted?
Issue Time Tracking
-------------------
Worklog Id: (was: 843363)
Time Spent: 5h (was: 4h 50m)
> Deprecate older APIs in the HMS
> -------------------------------
>
> Key: HIVE-26537
> URL: https://issues.apache.org/jira/browse/HIVE-26537
> Project: Hive
> Issue Type: Improvement
> Affects Versions: 4.0.0-alpha-1, 4.0.0-alpha-2
> Reporter: Sai Hemanth Gantasala
> Assignee: Sai Hemanth Gantasala
> Priority: Critical
> Labels: hive-4.0.0-must, pull-request-available
> Time Spent: 5h
> Remaining Estimate: 0h
>
> This Jira is to track the clean-up(deprecate older APIs and point the HMS
> client to the newer APIs) work in the hive metastore server.
> More details will be added here soon.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
