[
https://issues.apache.org/jira/browse/HIVE-11495?focusedWorklogId=836874&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-836874
]
ASF GitHub Bot logged work on HIVE-11495:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/23 12:07
Start Date: 04/Jan/23 12:07
Worklog Time Spent: 10m
Work Description: SourabhBadhya commented on code in PR #3908:
URL: https://github.com/apache/hive/pull/3908#discussion_r1061415809
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnErrorMsg.java:
##########
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.metastore.txn;
+
+/**
+ * The following class represents all the error messages that are handled for
aborts.
+ */
+public enum TxnErrorMsg {
Review Comment:
All these messages are written based on where `abortTxn()`/`abortTxns()` is
called. This represents the totality of how transactions are aborted from
HiveServer. Anything else has not come from Hiveserver but rather from other
services which might use transactional features of Hive (I have represented
them here as NONE). These are the only reasons where abort is done.
Issue Time Tracking
-------------------
Worklog Id: (was: 836874)
Time Spent: 3h 10m (was: 3h)
> Add aborted reason to transaction information.
> ----------------------------------------------
>
> Key: HIVE-11495
> URL: https://issues.apache.org/jira/browse/HIVE-11495
> Project: Hive
> Issue Type: Improvement
> Components: Metastore, Transactions
> Affects Versions: 1.0.0
> Reporter: Eugene Koifman
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> Should add TXNS.COMMENT field or something like that so that if the system
> aborts a transaction (due to timeout, for example) we can add a message to
> that effect to the aborted transaction.
> Another reason: Commit can fail due to a conflicting write from another txn
> (since HIVE-13395)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
