[ 
https://issues.apache.org/jira/browse/HIVE-26869?focusedWorklogId=836770&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-836770
 ]

ASF GitHub Bot logged work on HIVE-26869:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jan/23 00:30
            Start Date: 04/Jan/23 00:30
    Worklog Time Spent: 10m 
      Work Description: cnauroth commented on PR #3873:
URL: https://github.com/apache/hive/pull/3873#issuecomment-1370361462

   @amanraj2520 , I don't think 
[HDFS-13408](https://issues.apache.org/jira/browse/HDFS-13408) would be 
related, because I think that was a problem specific to Windows, and this test 
seems to be having a problem handling the parameterized warehouse directory, 
not the base testing directory.
   
   I think I figured it out. 
[`MetaStoreTestUtils#startMetaStoreWithRetry`](https://github.com/apache/hive/blob/branch-3/standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/MetaStoreTestUtils.java#L108)
 sets the warehouse directory as the new `metastore.warehouse.dir` property. 
[`AbstractHiveService#get/setWareHouseDir`](https://github.com/apache/hive/blob/branch-3/itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/AbstractHiveService.java#L92-L100)
 later works with the deprecated `hive.metastore.warehouse.dir` property. 
`MetastoreConf` will take care of resolving requests for the new property to 
values under the old property, but not vice versa.
   
   I found that on master, 
[HIVE-19104](https://issues.apache.org/jira/browse/HIVE-19104) included an 
additional line in 
[MiniHs2](https://github.com/apache/hive/blob/master/itests/util/src/main/java/org/apache/hive/jdbc/miniHS2/MiniHS2.java#L378)
 to make sure these 2 properties would stay in sync for test runs. I can get 
`TestHS2ImpersonationWithRemoteMS` to pass after applying a slightly modified 
version of that patch.
   
   I'll let you know when I have a pull request ready.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 836770)
    Time Spent: 1h 50m  (was: 1h 40m)

> Backport of HIVE-25250 Branch-3: Fix 
> TestHS2ImpersonationWithRemoteMS.testImpersonation
> ---------------------------------------------------------------------------------------
>
>                 Key: HIVE-26869
>                 URL: https://issues.apache.org/jira/browse/HIVE-26869
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Aman Raj
>            Assignee: Aman Raj
>            Priority: Critical
>              Labels: pull-request-available
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to