[
https://issues.apache.org/jira/browse/HIVE-26837?focusedWorklogId=836500&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-836500
]
ASF GitHub Bot logged work on HIVE-26837:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/23 05:27
Start Date: 03/Jan/23 05:27
Worklog Time Spent: 10m
Work Description: saihemanth-cloudera commented on code in PR #3854:
URL: https://github.com/apache/hive/pull/3854#discussion_r1060286475
##########
ql/src/test/results/clientpositive/llap/ctlt_translate_external.q.out:
##########
@@ -0,0 +1,108 @@
+PREHOOK: query: create table test_mm(empno int, name string) partitioned
by(dept string) stored as orc tblproperties('transactional'='true',
'transactional_properties'='default')
+PREHOOK: type: CREATETABLE
+PREHOOK: Output: database:default
+PREHOOK: Output: default@test_mm
+POSTHOOK: query: create table test_mm(empno int, name string) partitioned
by(dept string) stored as orc tblproperties('transactional'='true',
'transactional_properties'='default')
+POSTHOOK: type: CREATETABLE
+POSTHOOK: Output: database:default
+POSTHOOK: Output: default@test_mm
+PREHOOK: query: create table test_external like test_mm
+PREHOOK: type: CREATETABLE
+PREHOOK: Output: database:default
+PREHOOK: Output: default@test_external
+POSTHOOK: query: create table test_external like test_mm
+POSTHOOK: type: CREATETABLE
+POSTHOOK: Output: database:default
+POSTHOOK: Output: default@test_external
+PREHOOK: query: desc formatted test_external
+PREHOOK: type: DESCTABLE
+PREHOOK: Input: default@test_external
+POSTHOOK: query: desc formatted test_external
+POSTHOOK: type: DESCTABLE
+POSTHOOK: Input: default@test_external
+# col_name data_type comment
+empno int
+name string
+
+# Partition Information
+# col_name data_type comment
+dept string
+
+# Detailed Table Information
+Database: default
+#### A masked pattern was here ####
+Retention: 0
+#### A masked pattern was here ####
+Table Type: MANAGED_TABLE
+Table Parameters:
+ COLUMN_STATS_ACCURATE {\"BASIC_STATS\":\"true\"}
+ bucketing_version 2
+ numFiles 0
+ numPartitions 0
+ numRows 0
+ rawDataSize 0
+ totalSize 0
+ transactional true
+ transactional_properties default
+#### A masked pattern was here ####
Review Comment:
@ramesh0201 - There are a couple of other classes that distinguish managed
and external locations but those are irrelevant to the current functionality.
So I would suggest adding a new method to this class. This new method would use
an HMS client that is built based on configs as you mentioned in the above .q
file, and use this client to create a table so that the created table is
translated to an external table based on the configs, then we can do an assert
on the table locations.
Issue Time Tracking
-------------------
Worklog Id: (was: 836500)
Time Spent: 1.5h (was: 1h 20m)
> CTLT with hive.create.as.external.legacy as true creates managed table
> instead of external table
> ------------------------------------------------------------------------------------------------
>
> Key: HIVE-26837
> URL: https://issues.apache.org/jira/browse/HIVE-26837
> Project: Hive
> Issue Type: Bug
> Components: HiveServer2
> Reporter: Ramesh Kumar Thangarajan
> Assignee: Ramesh Kumar Thangarajan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> When CTLT is used with the config hive.create.as.external.legacy=true, it
> still creates managed table by default. Use below to reproduce.
> create external table test_ext(empno int, name string) partitioned by(dept
> string) stored as orc;
> desc formatted test_ext;
> set hive.create.as.external.legacy=true;
> create table test_external like test_ext;
> desc formatted test_external;
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
