[
https://issues.apache.org/jira/browse/HIVE-26880?focusedWorklogId=836388&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-836388
]
ASF GitHub Bot logged work on HIVE-26880:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jan/23 11:08
Start Date: 02/Jan/23 11:08
Worklog Time Spent: 10m
Work Description: zabetak commented on code in PR #3886:
URL: https://github.com/apache/hive/pull/3886#discussion_r1059967623
##########
service/pom.xml:
##########
@@ -291,13 +291,6 @@
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.apache.directory.client.ldap</groupId>
- <artifactId>ldap-client-api</artifactId>
- <version>${apache-directory-clientapi.version}</version>
- <scope>test</scope>
- </dependency>
-
<dependency>
<groupId>org.apache.directory.server</groupId>
<artifactId>apacheds-server-integ</artifactId>
Review Comment:
Can you clarify why we don't want to `exclude ldap-client-api` from here as
it was done in the original commit in master
(https://github.com/apache/hive/commit/5581eb8a74a4f33b35b7bf70d9ec4e9a95f3b8a0).
When I run `mvn dependency:tree` in service module I see the
`org.apache.directory.client.ldap:ldap-client-api` dependency coming
transitively.
```
[INFO] +- org.apache.directory.server:apacheds-server-integ:jar:1.5.7:test
[INFO] | +-
org.apache.directory.server:apacheds-interceptor-kerberos:jar:1.5.7:test
[INFO] | | +- org.apache.directory.server:apacheds-core:jar:1.5.7:test
[INFO] | | | +-
org.apache.directory.server:apacheds-core-api:jar:1.5.7:test
[INFO] | | | | +-
org.apache.directory.server:apacheds-core-entry:jar:1.5.7:test
[INFO] | | | | \-
org.apache.directory.server:apacheds-core-constants:jar:1.5.7:test
[INFO] | | | +- org.apache.directory.server:apacheds-utils:jar:1.5.7:test
[INFO] | | | \- bouncycastle:bcprov-jdk15:jar:140:test
[INFO] | | \-
org.apache.directory.server:apacheds-kerberos-shared:jar:1.5.7:test
[INFO] | | +-
org.apache.directory.server:apacheds-core-jndi:jar:1.5.7:test
[INFO] | | \-
org.apache.directory.server:apacheds-protocol-shared:jar:1.5.7:test
[INFO] | +- org.apache.directory.server:apacheds-core-integ:jar:1.5.7:test
[INFO] | +- ldapsdk:ldapsdk:jar:4.1:test
[INFO] | +- org.apache.directory.client.ldap:ldap-client-api:jar:0.1:test
```
Issue Time Tracking
-------------------
Worklog Id: (was: 836388)
Time Spent: 40m (was: 0.5h)
> Upgrade Apache Directory Server to 1.5.7 for release 3.2.
> ---------------------------------------------------------
>
> Key: HIVE-26880
> URL: https://issues.apache.org/jira/browse/HIVE-26880
> Project: Hive
> Issue Type: Improvement
> Components: Test
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Minor
> Labels: hive-3.2.0-must, pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> branch-3 uses Apache Directory Server in some tests. It currently uses
> version 1.5.6. This version has a transitive dependency to a SNAPSHOT, making
> it awkward to build and release. We can upgrade to 1.5.7 to remove the
> SNAPSHOT dependency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
