[
https://issues.apache.org/jira/browse/HIVE-26778?focusedWorklogId=829394&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-829394
]
ASF GitHub Bot logged work on HIVE-26778:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Nov/22 16:15
Start Date: 28/Nov/22 16:15
Worklog Time Spent: 10m
Work Description: kasakrisz commented on code in PR #3807:
URL: https://github.com/apache/hive/pull/3807#discussion_r1033745618
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g:
##########
@@ -141,7 +141,11 @@ binOpExpression
(
(key = Identifier op = operator value = DateLiteral)
|
+ (key = Identifier op = operator keyword = KW_DATE value =
StringLiteral)
+ |
Review Comment:
Seems that DateLiteral supports optional `date` keyword prefix but does not
support quotes:
https://github.com/apache/hive/blob/2fb969c6c6c7ebc9d2c34e27152c147aa34d7ff9/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g#L464-L467
How about improve `DateString` by adding a quoted alternative
```
fragment DateString
:
'\'' (Digit)(Digit)(Digit)(Digit) '-' (Digit)(Digit) '-' (Digit)(Digit)
'\''
| (Digit)(Digit)(Digit)(Digit) '-' (Digit)(Digit) '-' (Digit)(Digit)
;
```
instead of adding these alternatives to all occurrences where `DateLiteral`
is referenced.
Btw I don't know why `DateString` requires quotes in the first place since
`StringLiteral` has
Issue Time Tracking
-------------------
Worklog Id: (was: 829394)
Time Spent: 50m (was: 40m)
> Pushdown Date data type to metastore via direct sql / JDO
> ---------------------------------------------------------
>
> Key: HIVE-26778
> URL: https://issues.apache.org/jira/browse/HIVE-26778
> Project: Hive
> Issue Type: Bug
> Reporter: Syed Shameerur Rahman
> Assignee: Syed Shameerur Rahman
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The original feature to push down date data type while doing partition
> pruning via direct sql/JDO was added as part of the jira :
> https://issues.apache.org/jira/browse/HIVE-5679
> Since the behavior of Hive has changed with CBO, Now when CBO is turned on,
> The date data types are not pushed down to metastore due to CBO adding extra
> keyword 'DATE' with the original filter since the filter parser is not
> handled to parse this extra keyword it fails and hence the date data type is
> not pushed down to the metastore.
> {code:java}
> select * from test_table where date_col = '2022-01-01';
> {code}
> When CBO is turned on, The filter predicate generated is
> date_col=DATE'2022-01-01' which the filter parser fails to recognize.
>
> *Steps to reproduce*
> The following query will generate "{color:#6a8759}Error parsing partition
> filter; lexer error"
> [https://github.com/apache/hive/blob/master/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/PartFilterExprUtil.java#L128]{color}
>
> {color:#172b4d}When CBO is turned off (set hive.cbo.enable=false) we don't
> see this error message.{color}
> {code:java}
> create table part_time(a int) partitioned by(date_c date);
> insert into part_time partition(date_c='2000-01-01') values (1);
> insert into part_time partition(date_c='2000-02-01') values (1);
> insert into part_time partition(date_c='2000-03-01') values (1);
> select * from part_time where date_c = '2000-03-01';
> {code}
>
>
> *Performance Improvement*
> In my testing setup of table having 10k partitions in the table. When we do a
> select query on one of the partitions without the change it was 300 ms and
> after the change it was 14 ms.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
