[
https://issues.apache.org/jira/browse/HIVE-26716?focusedWorklogId=829312&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-829312
]
ASF GitHub Bot logged work on HIVE-26716:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Nov/22 13:23
Start Date: 28/Nov/22 13:23
Worklog Time Spent: 10m
Work Description: veghlaci05 commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1033536788
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/RebalanceQueryCompactor.java:
##########
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.ql.txn.compactor;
+
+import com.google.common.collect.Lists;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hive.common.ValidWriteIdList;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.metastore.api.CompactionType;
+import org.apache.hadoop.hive.metastore.api.Partition;
+import org.apache.hadoop.hive.metastore.api.StorageDescriptor;
+import org.apache.hadoop.hive.metastore.api.Table;
+import org.apache.hadoop.hive.metastore.txn.CompactionInfo;
+import org.apache.hadoop.hive.ql.io.AcidDirectory;
+import org.apache.hadoop.hive.ql.io.AcidUtils;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+import java.io.IOException;
+import java.util.List;
+import java.util.stream.Collectors;
+
+final class RebalanceQueryCompactor extends QueryCompactor {
+ @Override
+ void runCompaction(HiveConf hiveConf, Table table, Partition partition,
StorageDescriptor storageDescriptor,
+ ValidWriteIdList writeIds, CompactionInfo compactionInfo,
AcidDirectory dir)
+ throws IOException, HiveException {
+ AcidUtils
+ .setAcidOperationalProperties(hiveConf, true,
AcidUtils.getAcidOperationalProperties(table.getParameters()));
+
+ HiveConf conf = new HiveConf(hiveConf);
+ // Set up the session for driver.
+ conf.set(HiveConf.ConfVars.HIVE_QUOTEDID_SUPPORT.varname, "column");
+
+ String tmpPrefix = table.getDbName() + "_tmp_compactor_" +
table.getTableName() + "_";
+ String tmpTableName = tmpPrefix + System.currentTimeMillis();
+ Path tmpTablePath =
QueryCompactor.Util.getCompactionResultDir(storageDescriptor, writeIds,
+ conf, true, false, false, null);
+
+ //TODO: This is quite expensive, a better way should be found to get the
number of buckets for an implicitly bucketed table
+ int numBuckets = dir.getFiles().stream()
Review Comment:
Unfortunately no, the number of buckets is not stored as statistics, because
it is stored outside of stats (as metadata), but only for explicitly bucketed
tables.
Issue Time Tracking
-------------------
Worklog Id: (was: 829312)
Time Spent: 14h (was: 13h 50m)
> Query based Rebalance compaction on full acid tables
> ----------------------------------------------------
>
> Key: HIVE-26716
> URL: https://issues.apache.org/jira/browse/HIVE-26716
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: ACID, compaction, pull-request-available
> Time Spent: 14h
> Remaining Estimate: 0h
>
> Support rebalancing compaction on fully ACID tables.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
