[ https://issues.apache.org/jira/browse/HIVE-26243?focusedWorklogId=825197&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-825197 ]
ASF GitHub Bot logged work on HIVE-26243: ----------------------------------------- Author: ASF GitHub Bot Created on: 11/Nov/22 08:34 Start Date: 11/Nov/22 08:34 Worklog Time Spent: 10m Work Description: deniskuzZ commented on code in PR #3317: URL: https://github.com/apache/hive/pull/3317#discussion_r1019992084 ########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/common/histogram/KllHistogramEstimator.java: ########## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hive.common.histogram; + +import org.apache.datasketches.kll.KllFloatsSketch; +import org.apache.hadoop.hive.common.histogram.kll.KllUtils; +import org.apache.hadoop.hive.common.type.HiveDecimal; +import org.apache.hadoop.hive.ql.util.JavaDataModel; + +import java.io.ByteArrayOutputStream; +import java.io.IOException; + +public class KllHistogramEstimator { Review Comment: maybe `org.apache.hadoop.hive.ql.udf.generic.histogram` in hive-exec? @szlta what do you think? Issue Time Tracking ------------------- Worklog Id: (was: 825197) Time Spent: 4.5h (was: 4h 20m) > Add vectorized implementation of the 'ds_kll_sketch' UDAF > --------------------------------------------------------- > > Key: HIVE-26243 > URL: https://issues.apache.org/jira/browse/HIVE-26243 > Project: Hive > Issue Type: Improvement > Components: UDF, Vectorization > Affects Versions: 4.0.0-alpha-2 > Reporter: Alessandro Solimando > Assignee: Alessandro Solimando > Priority: Major > Labels: pull-request-available > Time Spent: 4.5h > Remaining Estimate: 0h > > _ds_kll_sketch_ UDAF does not have a vectorized implementation at the moment, > the present ticket aims at bridging this gap. > This is particularly important because vectorization has an "all or nothing" > approach, so if this function is used at the side of vectorized functions, > they won't be able to benefit from vectorized execution. -- This message was sent by Atlassian Jira (v8.20.10#820010)