[ https://issues.apache.org/jira/browse/HIVE-26685?focusedWorklogId=822480&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822480 ]
ASF GitHub Bot logged work on HIVE-26685: ----------------------------------------- Author: ASF GitHub Bot Created on: 01/Nov/22 22:36 Start Date: 01/Nov/22 22:36 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #3721: URL: https://github.com/apache/hive/pull/3721#issuecomment-1299314934 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=3721) [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3721&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3721&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3721&resolved=false&types=BUG) [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3721&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3721&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3721&resolved=false&types=VULNERABILITY) [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3721&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3721&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=3721&resolved=false&types=SECURITY_HOTSPOT) [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3721&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3721&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=3721&resolved=false&types=CODE_SMELL) [![No Coverage information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo-16px.png 'No Coverage information')](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3721&metric=coverage&view=list) No Coverage information [![No Duplication information](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo-16px.png 'No Duplication information')](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=3721&metric=duplicated_lines_density&view=list) No Duplication information Issue Time Tracking ------------------- Worklog Id: (was: 822480) Remaining Estimate: 0h Time Spent: 10m > Improve Path name escaping / unescaping performance > --------------------------------------------------- > > Key: HIVE-26685 > URL: https://issues.apache.org/jira/browse/HIVE-26685 > Project: Hive > Issue Type: Improvement > Components: Hive > Affects Versions: All Versions > Reporter: James Petty > Priority: Minor > Attachments: HIVE-26685.1.patch > > Time Spent: 10m > Remaining Estimate: 0h > > When escaping / unescaping partition path part names, the existing logic > incurs significant avoidable overhead by copying each character sequentially > into a new StringBuilder even when no escaping/unescaping is necessary as > well as using String.format to escape characters inside of the inner loop. > > The included patch to improve the performance of these operations refactors > two static method implementations, but requires no external API surface or > user-visible behavior changes. This change is applicable and portable to a > wide range of Hive versions from branch-0.6 onward when the initial method > implementations were added. -- This message was sent by Atlassian Jira (v8.20.10#820010)