[
https://issues.apache.org/jira/browse/HIVE-26684?focusedWorklogId=822119&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-822119
]
ASF GitHub Bot logged work on HIVE-26684:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Oct/22 21:48
Start Date: 31/Oct/22 21:48
Worklog Time Spent: 10m
Work Description: cnauroth commented on code in PR #3717:
URL: https://github.com/apache/hive/pull/3717#discussion_r1009901203
##########
pom.xml:
##########
@@ -95,6 +95,7 @@
<maven.checkstyle.plugin.version>2.17</maven.checkstyle.plugin.version>
<maven.build-helper.plugin.version>1.12</maven.build-helper.plugin.version>
<maven.eclipse.plugin.version>2.10</maven.eclipse.plugin.version>
+ <maven.shade.plugin.version>3.4.1</maven.shade.plugin.version>
Review Comment:
Hello @nrg4878 . Thank you for the reply.
The Hive root pom.xml specifies the common Apache pom as its parent:
```
<parent>
<groupId>org.apache</groupId>
<artifactId>apache</artifactId>
<version>23</version>
</parent>
```
From the output of `mvn help:effective-pom`, I can see that pom specifies
maven-shade-plugin version 3.1.1, so for the maven-shade-plugin invocations in
Hive, this is the version getting picked up:
https://github.com/apache/maven-apache-parent/blob/apache-23/pom.xml#L308
There is a more recent version 27 release of the Apache parent pom, which
pins to maven-shade-plugin 3.3.0:
https://github.com/apache/maven-apache-parent/blob/apache-27/pom.xml#L301
I'm not sure if that version is also sufficient for the bugs I'm trying to
address. I didn't take the approach of upgrading the parent pom, because it's
potentially a larger change impacting more than just the maven-shade-plugin fix
I was trying to target.
Issue Time Tracking
-------------------
Worklog Id: (was: 822119)
Time Spent: 40m (was: 0.5h)
> Upgrade maven-shade-plugin from 3.4.1 for bug fixes.
> ----------------------------------------------------
>
> Key: HIVE-26684
> URL: https://issues.apache.org/jira/browse/HIVE-26684
> Project: Hive
> Issue Type: Bug
> Components: Build Infrastructure
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The Hive build currently runs with maven-shade-plugin version 3.1.1, released
> in April 2018. This issue proposes to upgrade to the latest version, 3.4.1,
> released in October 2022. See HIVE-26648 for an example of another patch that
> is blocked due to a bug in version 3.1.1.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
