[ 
https://issues.apache.org/jira/browse/HIVE-26580?focusedWorklogId=821299&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-821299
 ]

ASF GitHub Bot logged work on HIVE-26580:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Oct/22 06:31
            Start Date: 28/Oct/22 06:31
    Worklog Time Spent: 10m 
      Work Description: rkirtir commented on code in PR #3708:
URL: https://github.com/apache/hive/pull/3708#discussion_r1007691246


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/process/show/compactions/ShowCompactionsDesc.java:
##########
@@ -45,10 +45,12 @@ public class ShowCompactionsDesc implements DDLDesc, 
Serializable {
     private final String compactionType;
     private final String compactionStatus;
     private final Map<String, String> partSpec;
+    private final short limit;
+    private final String order;
 
 
     public ShowCompactionsDesc(Path resFile, long compactionId, String dbName, 
String tbName, String poolName, String compactionType,
-                               String compactionStatus, Map<String, String> 
partSpec) {
+                               String compactionStatus, Map<String, String> 
partSpec, short limit, String order) {

Review Comment:
   fixed



##########
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java:
##########
@@ -1984,4 +1984,28 @@ public ParseContext getParseContext() {
     return pCtx;
   }
 
+  public PTFInvocationSpec.OrderSpec processOrderSpec(ASTNode sortNode) {
+    PTFInvocationSpec.OrderSpec oSpec = new PTFInvocationSpec.OrderSpec();

Review Comment:
   fixed





Issue Time Tracking
-------------------

    Worklog Id:     (was: 821299)
    Time Spent: 1h 40m  (was: 1.5h)

> SHOW COMPACTIONS should support ordering and limiting functionality in 
> filtering options
> ----------------------------------------------------------------------------------------
>
>                 Key: HIVE-26580
>                 URL: https://issues.apache.org/jira/browse/HIVE-26580
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: KIRTI RUGE
>            Assignee: KIRTI RUGE
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> SHOW COMPACTION should provide ordering by defied table . It should also 
> support limitation of fetched records



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to