[
https://issues.apache.org/jira/browse/HIVE-26636?focusedWorklogId=820035&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-820035
]
ASF GitHub Bot logged work on HIVE-26636:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Oct/22 13:39
Start Date: 25/Oct/22 13:39
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3681:
URL: https://github.com/apache/hive/pull/3681#discussion_r1004495738
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCosh.java:
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.ql.udf;
+
+import org.apache.hadoop.hive.ql.exec.Description;
+import org.apache.hadoop.hive.ql.exec.vector.VectorizedExpressions;
+import
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.FuncCoshDoubleToDouble;
+import
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.FuncCoshLongToDouble;
+import org.apache.hadoop.hive.serde2.io.DoubleWritable;
+
+/**
+ * UDFCosh.
+ */
+@Description(name = "cosh",
+ value = "_FUNC_(x) - returns the cosineh of x (x is in radians)",
Review Comment:
returns the `hyperbolic cosine` ?
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:
##########
@@ -32,6 +32,7 @@
import java.util.regex.Pattern;
import java.util.regex.PatternSyntaxException;
+import org.apache.hadoop.hive.ql.udf.*;
Review Comment:
please avoid wildcard imports
##########
vector-code-gen/src/org/apache/hadoop/hive/tools/GenVectorCode.java:
##########
@@ -1100,10 +1100,16 @@ public class GenVectorCode extends Task {
{"ColumnUnaryFunc", "FuncAbs", "long", "long", "MathExpr.abs", "", "",
"", ""},
{"ColumnUnaryFunc", "FuncSin", "double", "double", "Math.sin", "", "",
"", ""},
{"ColumnUnaryFunc", "FuncSin", "double", "long", "Math.sin", "(double)",
"", "", ""},
+ {"ColumnUnaryFunc", "FuncSinh", "double", "double",
"StrictMath.sinh", "", "", "", ""},
Review Comment:
please check the line formatting
##########
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFTanh.java:
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.udf;
+
+import org.apache.hadoop.hive.ql.exec.Description;
+import org.apache.hadoop.hive.ql.exec.vector.VectorizedExpressions;
+import
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.FuncTanhDoubleToDouble;
+import
org.apache.hadoop.hive.ql.exec.vector.expressions.gen.FuncTanhLongToDouble;
+import org.apache.hadoop.hive.serde2.io.DoubleWritable;
+
+@Description(name = "tanh",
+ value = "_FUNC_(x) - returns the tangent hyperbolic of x (x is in
radians)",
Review Comment:
returns the `hyperbolic tangent`?
Issue Time Tracking
-------------------
Worklog Id: (was: 820035)
Time Spent: 40m (was: 0.5h)
> Hyperbolic functions
> ----------------------
>
> Key: HIVE-26636
> URL: https://issues.apache.org/jira/browse/HIVE-26636
> Project: Hive
> Issue Type: New Feature
> Reporter: Gopinath
> Assignee: Gopinath
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Adding hyperbolic functions.
> |Function|Description|Example|Result|
> |sinh (x)|hyperbolic sine|sinh(0)|0|
> |cosh (x)|hyperbolic cosine|cosh(0)|1|
> |tanh (x)|hyperbolic tangent|tanh(0)|0|
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
