[ https://issues.apache.org/jira/browse/HIVE-26627?focusedWorklogId=817499&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-817499 ]
ASF GitHub Bot logged work on HIVE-26627: ----------------------------------------- Author: ASF GitHub Bot Created on: 17/Oct/22 07:59 Start Date: 17/Oct/22 07:59 Worklog Time Spent: 10m Work Description: zabetak closed pull request #3668: HIVE-26627: Remove HiveRelBuilder.aggregateCall override and refactor callers to use existing public methods URL: https://github.com/apache/hive/pull/3668 Issue Time Tracking ------------------- Worklog Id: (was: 817499) Time Spent: 40m (was: 0.5h) > Remove HiveRelBuilder.aggregateCall override and refactor callers to use > existing public methods > ------------------------------------------------------------------------------------------------ > > Key: HIVE-26627 > URL: https://issues.apache.org/jira/browse/HIVE-26627 > Project: Hive > Issue Type: Task > Components: CBO > Reporter: Stamatis Zampetakis > Assignee: Stamatis Zampetakis > Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > The HiveRelBuilder overrides > [aggregateCall|https://github.com/apache/hive/blob/8c3567ea8e423b202cde370f4d3fb401bcc23e46/ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelBuilder.java#L246] > from its superclass simply to expose and use it in > HiveRewriteToDataSketchesRules. > However, there is no real need to override this method since we can achieve > the same outcome by using existing methods in RelBuilder which are easier to > use and understand. Furthermore it is safer to depend on public APIs since > are more stable in general. -- This message was sent by Atlassian Jira (v8.20.10#820010)