[ 
https://issues.apache.org/jira/browse/HIVE-26471?focusedWorklogId=815479&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815479
 ]

ASF GitHub Bot logged work on HIVE-26471:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Oct/22 07:17
            Start Date: 11/Oct/22 07:17
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #3645:
URL: https://github.com/apache/hive/pull/3645#discussion_r991899820


##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/metrics/AcidMetricService.java:
##########
@@ -333,7 +336,10 @@ public static void 
updateMetricsFromShowCompact(ShowCompactResponse showCompactR
       }
     }
 
-    
Metrics.getOrCreateMapMetrics(COMPACTION_POOLS_ITEM_COUNT).update(metricData.getPoolCount());
+    
Metrics.getOrCreateMapMetrics(COMPACTION_POOLS_INITIATED_ITEM_COUNT).update(metricData.getInitiatedPoolCount());
+    
Metrics.getOrCreateMapMetrics(COMPACTION_POOLS_WORKING_ITEM_COUNT).update(metricData.getWorkingPoolCount());

Review Comment:
   maybe, getWorkingCountPerPool?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 815479)
    Time Spent: 3h 20m  (was: 3h 10m)

> New metric for Compaction pooling
> ---------------------------------
>
>                 Key: HIVE-26471
>                 URL: https://issues.apache.org/jira/browse/HIVE-26471
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>            Reporter: László Végh
>            Assignee: László Végh
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0-alpha-2
>
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> To be able to properly supervise the pool based compaction, a new metric is 
> required:
> Number of 'Initiated' compaction requests per compaction pool.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to