[ https://issues.apache.org/jira/browse/HIVE-26196?focusedWorklogId=815297&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-815297 ]
ASF GitHub Bot logged work on HIVE-26196: ----------------------------------------- Author: ASF GitHub Bot Created on: 10/Oct/22 16:23 Start Date: 10/Oct/22 16:23 Worklog Time Spent: 10m Work Description: asolimando opened a new pull request, #3655: URL: https://github.com/apache/hive/pull/3655 …num: fix analysis for the master branch) <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute 2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary 3. Ensure you have added or run the appropriate tests for your PR: 4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'. 5. Be sure to keep the PR description updated to reflect all changes. 6. Please write your PR title to summarize what this PR proposes. 7. If possible, provide a concise example to reproduce the issue for a faster review. --> ### What changes were proposed in this pull request? <!-- Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below. 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers. 2. If you fix some SQL features, you can provide some references of other DBMSes. 3. If there is design documentation, please add the link. 4. If there is a discussion in the mailing list, please add the link. --> ### Why are the changes needed? <!-- Please clarify why the changes are needed. For instance, 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug, you can clarify why it is a bug. --> ### Does this PR introduce _any_ user-facing change? <!-- Note that it means *any* user-facing change including all aspects such as the documentation fix. If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description, screenshot and/or a reproducable example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Hive versions or within the unreleased branches such as master. If no, write 'No'. --> ### How was this patch tested? <!-- If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. If tests were not added, please describe why they were not added and/or why it was difficult to add. --> Issue Time Tracking ------------------- Worklog Id: (was: 815297) Time Spent: 2h 50m (was: 2h 40m) > Integrate Sonar analysis for the master branch and PRs > ------------------------------------------------------ > > Key: HIVE-26196 > URL: https://issues.apache.org/jira/browse/HIVE-26196 > Project: Hive > Issue Type: Improvement > Components: Build Infrastructure > Affects Versions: 4.0.0-alpha-2 > Reporter: Alessandro Solimando > Assignee: Alessandro Solimando > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0-alpha-2 > > Time Spent: 2h 50m > Remaining Estimate: 0h > > The aim of the ticket is to integrate SonarCloud analysis for the master > branch and PRs. > The ticket does not cover test coverage at the moment (it can be added in > follow-up tickets, if there is enough interest). > From preliminary tests, the analysis step requires 30 additional minutes for > the pipeline, but this step is run in parallel with the test run, so the > total end-to-end run-time is not affected. > The idea for this first integration is to track code quality metrics over new > commits in the master branch and for PRs, without any quality gate rules > (i.e., the analysis will never fail, independently of the values of the > quality metrics). > An example of analysis is available in the ASF Sonar account for Hive: [PR > analysis|https://sonarcloud.io/summary/new_code?id=apache_hive&pullRequest=3254] > After integrating the changes, PRs will also be decorated with a link to the > analysis to be able to better evaluate any pain points of the contribution at > an earlier stage, making the life of the reviewers a bit easier. -- This message was sent by Atlassian Jira (v8.20.10#820010)