[ https://issues.apache.org/jira/browse/HIVE-26498?focusedWorklogId=807405&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-807405 ]
ASF GitHub Bot logged work on HIVE-26498: ----------------------------------------- Author: ASF GitHub Bot Created on: 09/Sep/22 13:20 Start Date: 09/Sep/22 13:20 Worklog Time Spent: 10m Work Description: lcspinter commented on code in PR #3552: URL: https://github.com/apache/hive/pull/3552#discussion_r967064122 ########## storage-api/src/java/org/apache/hadoop/hive/common/type/SnapshotContext.java: ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.common.type; + +import java.util.Objects; + +public class SnapshotContext { Review Comment: nit: just a few lines about what this value object is used for and where Issue Time Tracking ------------------- Worklog Id: (was: 807405) Time Spent: 5h (was: 4h 50m) > Implement MV maintenance with Iceberg sources using full rebuild > ---------------------------------------------------------------- > > Key: HIVE-26498 > URL: https://issues.apache.org/jira/browse/HIVE-26498 > Project: Hive > Issue Type: Sub-task > Components: Materialized views > Reporter: Krisztian Kasa > Assignee: Krisztian Kasa > Priority: Major > Labels: pull-request-available > Time Spent: 5h > Remaining Estimate: 0h > > {code} > set hive.support.concurrency=true; > set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager; > create external table tbl_ice(a int, b string, c int) stored by iceberg > stored as orc tblproperties ('format-version'='2'); > insert into tbl_ice values (1, 'one', 50), (2, 'two', 51), (3, 'three', 52), > (4, 'four', 53), (5, 'five', 54); > create materialized view mat1 as > select b, c from tbl_ice where c > 52; > insert into tbl_ice values (111, 'one', 55), (333, 'two', 56); > explain cbo > alter materialized view mat1 rebuild; > alter materialized view mat1 rebuild; > {code} > MV full rebuild plan > {code} > CBO PLAN: > HiveProject(b=[$1], c=[$2]) > HiveFilter(condition=[>($2, 52)]) > HiveTableScan(table=[[default, tbl_ice]], table:alias=[tbl_ice]) > {code} -- This message was sent by Atlassian Jira (v8.20.10#820010)