[ https://issues.apache.org/jira/browse/HIVE-25845?focusedWorklogId=805491&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805491 ]
ASF GitHub Bot logged work on HIVE-25845: ----------------------------------------- Author: ASF GitHub Bot Created on: 01/Sep/22 11:47 Start Date: 01/Sep/22 11:47 Worklog Time Spent: 10m Work Description: szlta commented on code in PR #3551: URL: https://github.com/apache/hive/pull/3551#discussion_r960552486 ########## ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedParquetRecordReader.java: ########## @@ -248,9 +245,12 @@ public void initialize( requestedSchema = DataWritableReadSupport .getRequestedSchema(indexAccess, columnNamesList, columnTypesList, fileSchema, configuration); - Path path = wrapPathForCache(filePath, cacheKey, configuration, blocks, cacheTag); + //TODO: For data cache this needs to be fixed and passed to reader. + //Path path = wrapPathForCache(filePath, cacheKey, configuration, blocks, cacheTag); Review Comment: I don't quite get this change. It essentially turns off LLAP data caching of Parquet bytes, I'm not sure if this was intentional. Issue Time Tracking ------------------- Worklog Id: (was: 805491) Time Spent: 2h 40m (was: 2.5h) > Support ColumnIndexes for Parq files > ------------------------------------ > > Key: HIVE-25845 > URL: https://issues.apache.org/jira/browse/HIVE-25845 > Project: Hive > Issue Type: Improvement > Reporter: Rajesh Balamohan > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > https://issues.apache.org/jira/browse/PARQUET-1201 > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/vector/VectorizedParquetRecordReader.java#L271-L273] -- This message was sent by Atlassian Jira (v8.20.10#820010)