[jira] [Work logged] (HIVE-25621) Alter table partition compact/concatenate commands should send HivePrivilegeObjects for Authz

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/HIVE-25621?focusedWorklogId=805271&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-805271
 ]

ASF GitHub Bot logged work on HIVE-25621:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Aug/22 15:17
            Start Date: 31/Aug/22 15:17
    Worklog Time Spent: 10m 
      Work Description: saihemanth-cloudera commented on code in PR #2731:
URL: https://github.com/apache/hive/pull/2731#discussion_r959716618


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/concatenate/AlterTableConcatenateDesc.java:
##########
@@ -44,7 +47,8 @@ public class AlterTableConcatenateDesc implements DDLDesc {
   private final TableDesc tableDesc;
 
   public AlterTableConcatenateDesc(TableName tableName, Map<String, String> 
partitionSpec, ListBucketingCtx lbCtx,
-      Path inputDir, Path outputDir, Class<? extends InputFormat> 
inputFormatClass, TableDesc tableDesc) {
+      Path inputDir, Path outputDir, Class<? extends InputFormat> 
inputFormatClass, TableDesc tableDesc) throws SemanticException {
+    super(AlterTableType.COMPACT, tableName, partitionSpec, null, false, 
false, null);

Review Comment:
   The idea behind behind this was: 
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/ddl/table/storage/concatenate/AlterTableConcatenateAnalyzer.java#L101
 I thought Concatenate is major type compaction. I will change this as you 
suggested.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 805271)
    Time Spent: 3h 20m  (was: 3h 10m)

> Alter table partition compact/concatenate commands should send 
> HivePrivilegeObjects for Authz
> ---------------------------------------------------------------------------------------------
>
>                 Key: HIVE-25621
>                 URL: https://issues.apache.org/jira/browse/HIVE-25621
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 4.0.0
>            Reporter: Sai Hemanth Gantasala
>            Assignee: Sai Hemanth Gantasala
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> # Run the following queries 
> Create table temp(c0 int) partitioned by (c1 int);
> Insert into temp values(1,1);
> ALTER TABLE temp PARTITION (c1=1) COMPACT 'minor';
> ALTER TABLE temp PARTITION (c1=1) CONCATENATE;
> Insert into temp values(1,1);
>  # The above compact/concatenate commands are currently not sending any hive 
> privilege objects for authorization. Hive needs to send these objects to 
> avoid malicious users doing any operation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)