[
https://issues.apache.org/jira/browse/HIVE-26500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
László Bodor updated HIVE-26500:
--------------------------------
Description:
{code}
Thread.sleep(5 * 1000); // give HMS time to handle close request
int numObjectsAfterClose = getJDOPersistanceManagerCacheSize();
assertTrue(numObjectsBeforeClose == numObjectsAfterClose);
{code}
1. easy fix: assertTrue(numObjectsBeforeClose == numObjectsAfterClose);
this tells nothing in case of assertionerror:
{code}
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:87)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertTrue(Assert.java:53)
at
org.apache.hadoop.hive.metastore.TestHiveMetaStore.testJDOPersistanceManagerCleanup(TestHiveMetaStore.java:3298)
{code}
should tell a more informative message with particular values
2. harder fix, maybe do it later
{code}
Thread.sleep(5 * 1000); // give HMS time to handle close request
{code}
sleep is always dangerous, cannot make sure it handled everything that we
expected
was:
{code}
Thread.sleep(5 * 1000); // give HMS time to handle close request
int numObjectsAfterClose = getJDOPersistanceManagerCacheSize();
assertTrue(numObjectsBeforeClose == numObjectsAfterClose);
{code}
1. easy fix: assertTrue(numObjectsBeforeClose == numObjectsAfterClose);
this tells nothing in case of assertionerror:
{code}
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:87)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertTrue(Assert.java:53)
at
org.apache.hadoop.hive.metastore.TestHiveMetaStore.testJDOPersistanceManagerCleanup(TestHiveMetaStore.java:3298)
{code}
should tell a more informative message with particular values
2. harder fix, maybe do it later
{code}
Thread.sleep(5 * 1000); // give HMS time to handle close request
{code}
sleep is always dangerous
> Improve TestHiveMetastore
> -------------------------
>
> Key: HIVE-26500
> URL: https://issues.apache.org/jira/browse/HIVE-26500
> Project: Hive
> Issue Type: Improvement
> Reporter: László Bodor
> Assignee: László Bodor
> Priority: Major
>
> {code}
> Thread.sleep(5 * 1000); // give HMS time to handle close request
> int numObjectsAfterClose = getJDOPersistanceManagerCacheSize();
> assertTrue(numObjectsBeforeClose == numObjectsAfterClose);
> {code}
> 1. easy fix: assertTrue(numObjectsBeforeClose == numObjectsAfterClose);
> this tells nothing in case of assertionerror:
> {code}
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:87)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at org.junit.Assert.assertTrue(Assert.java:53)
> at
> org.apache.hadoop.hive.metastore.TestHiveMetaStore.testJDOPersistanceManagerCleanup(TestHiveMetaStore.java:3298)
> {code}
> should tell a more informative message with particular values
> 2. harder fix, maybe do it later
> {code}
> Thread.sleep(5 * 1000); // give HMS time to handle close request
> {code}
> sleep is always dangerous, cannot make sure it handled everything that we
> expected
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
