[
https://issues.apache.org/jira/browse/HIVE-26414?focusedWorklogId=796879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796879
]
ASF GitHub Bot logged work on HIVE-26414:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Aug/22 13:18
Start Date: 01/Aug/22 13:18
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3457:
URL: https://github.com/apache/hive/pull/3457#discussion_r934518439
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -7983,7 +7984,17 @@ protected boolean enableColumnStatsCollecting() {
return true;
}
- private Path getCtasLocation(CreateTableDesc tblDesc) throws
SemanticException {
+ private Path getCtasLocation(CreateTableDesc tblDesc, boolean
createTableWithSuffix) throws SemanticException {
+ Path destinationPath = getCtasLocationWithoutSuffix(tblDesc);
+ if (createTableWithSuffix) {
+ long txnId = ctx.getHiveTxnManager().getCurrentTxnId();
+ String suffix = AcidUtils.getPathSuffix(txnId);
+ destinationPath = new Path(destinationPath.toString() + suffix);
+ }
+ return destinationPath;
+ }
+
+ private Path getCtasLocationWithoutSuffix(CreateTableDesc tblDesc) throws
SemanticException {
Review Comment:
please keep it as `getCtasLocation` and call overloaded
getCtasLocation(tblDesc, false)
Issue Time Tracking
-------------------
Worklog Id: (was: 796879)
Time Spent: 9h 10m (was: 9h)
> Aborted/Cancelled CTAS operations must initiate cleanup of uncommitted data
> ---------------------------------------------------------------------------
>
> Key: HIVE-26414
> URL: https://issues.apache.org/jira/browse/HIVE-26414
> Project: Hive
> Issue Type: Improvement
> Reporter: Sourabh Badhya
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9h 10m
> Remaining Estimate: 0h
>
> When a CTAS query fails before creation of table and after writing the data,
> the data is present in the directory and not cleaned up currently by the
> cleaner or any other mechanism currently. This is because the cleaner
> requires a table corresponding to what its cleaning. In order surpass such a
> situation, we can directly pass the relevant information to the cleaner so
> that such uncommitted data is deleted.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
