[ 
https://issues.apache.org/jira/browse/HIVE-26055?focusedWorklogId=786622&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-786622
 ]

ASF GitHub Bot logged work on HIVE-26055:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Jun/22 14:36
            Start Date: 30/Jun/22 14:36
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #3247:
URL: https://github.com/apache/hive/pull/3247#discussion_r911106279


##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLAuthorizationUtils.java:
##########
@@ -211,8 +213,24 @@ static RequiredPrivileges 
getPrivilegesFromMetaStore(IMetaStoreClient metastoreC
     RequiredPrivileges privs = getRequiredPrivsFromThrift(thrifPrivs);
 
     // add owner privilege if user is owner of the object
-    if (isOwner(metastoreClient, userName, curRoles, hivePrivObject)) {
-      privs.addPrivilege(SQLPrivTypeGrant.OWNER_PRIV);
+    try {

Review Comment:
   maybe just:
   ````
       try {
         if (isOwner(metastoreClient, userName, curRoles, hivePrivObject)) {
           privs.addPrivilege(SQLPrivTypeGrant.OWNER_PRIV);
         }
       } catch (HiveAuthzPluginException ex) {
         if (ex.getCause() instanceof NoSuchObjectException && ignoreUnknown) {
           privs.addPrivilege(SQLPrivTypeGrant.OWNER_PRIV);
         } else {
           throw ex;
         }
       }
   ````





Issue Time Tracking
-------------------

    Worklog Id:     (was: 786622)
    Time Spent: 5h 40m  (was: 5.5h)

> Fix the HivePrivilegesObjects for Alter table rename command
> ------------------------------------------------------------
>
>                 Key: HIVE-26055
>                 URL: https://issues.apache.org/jira/browse/HIVE-26055
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2, Security
>            Reporter: Sai Hemanth Gantasala
>            Assignee: Sai Hemanth Gantasala
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> Fix the HivePrivilegeObjects for Alter table rename query in a way that it 
> includes source table information in the output objects and destination table 
> information in the input objects.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to