[jira] [Work logged] (HIVE-26242) Compaction heartbeater improvements

[ASF GitHub Bot (Jira)]

Title: Message Title

ASF GitHub Bot added a worklog on HIVE-26242   deniskuzZ commented on PR #3303: URL: https://github.com/apache/hive/pull/3303#issuecomment-1168345079 > > I think we should do something like this: > > ``` > > ExecutorService executorService = CompactorUtil.createExecutorWithThreadFactory(numberOfWorkers, "CompactionHeartbeat-executor-thread-%d"); > > > > Future<?> submittedTask = heartbeatExecutor.scheduleAtFixedRate(() -> executorService.execute(heartbeater)); > > tasks.put(txnId, new TaskWrapper(heartbeater, submittedTask)); > > ``` > > What is the benefit of this construct? none, I was playing with it trying to extract CompletableFuture, so we can just call 'join' or 'get' instead on manual hacks in runnable Worklog entry: 10m logged by ASF GitHub Bot Change By: ASF GitHub Bot Time Spent: 8h 20m 8.5h Add Comment   This message was sent by Atlassian Jira (v8.20.10#820010-sha1:ace47f9)