[ https://issues.apache.org/jira/browse/HIVE-26265?focusedWorklogId=784281&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784281 ]
ASF GitHub Bot logged work on HIVE-26265: ----------------------------------------- Author: ASF GitHub Bot Created on: 23/Jun/22 15:43 Start Date: 23/Jun/22 15:43 Worklog Time Spent: 10m Work Description: pvary commented on code in PR #3365: URL: https://github.com/apache/hive/pull/3365#discussion_r905188429 ########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/events/AbortTxnEvent.java: ########## @@ -66,4 +75,12 @@ public Long getTxnId() { public TxnType getTxnType() { return txnType; } + + /** + * Review Comment: Please provide a description, like: ``` Returns the list of the db names which might have written anything in this transacion ``` Or anything better with nicer English 😄 Issue Time Tracking ------------------- Worklog Id: (was: 784281) Time Spent: 2h 20m (was: 2h 10m) > REPL DUMP should filter out OpenXacts and unneeded CommitXact/Abort. > -------------------------------------------------------------------- > > Key: HIVE-26265 > URL: https://issues.apache.org/jira/browse/HIVE-26265 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 > Reporter: francis pang > Assignee: francis pang > Priority: Major > Labels: pull-request-available > Time Spent: 2h 20m > Remaining Estimate: 0h > > REPL DUMP is replication all OpenXacts, even when they are from other non > replicated databases. This wastes space in the dump, and ends up opening > unneeded transactions during REPL LOAD. >  > Add a config property for replication that filters out OpenXact events during > REPL DUMP. During REPL LOAD, the txns can be implicitly opened when the > ALLOC_WRITE_ID is processed. For CommitTxn and AbortTxn, dump only if WRITE > ID was allocated. -- This message was sent by Atlassian Jira (v8.20.7#820007)