[ 
https://issues.apache.org/jira/browse/HIVE-12235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14975428#comment-14975428
 ] 

Szehon Ho commented on HIVE-12235:
----------------------------------

Uploading patch 2.  Cleans up the output, can you take a look?

I think there might be a separate issue I found when testing with unreachable 
hosts (faking some unreachable connect data in zookeeper).  The method 
ZookeeperHiveClientHelper.applyConfs() does not override host and port if they 
are already set (which they are after the first attempt).  Hence the reconnect 
is always attempted on the same host/port.  Do you think this an issue?  I can 
file another JIRA about this.

{noformat}
        if ((matcher.group(1).equals("hive.server2.thrift.bind.host"))
            && (connParams.getHost() == null)) {
          connParams.setHost(matcher.group(2));
        }
        if ((matcher.group(1).equals("hive.server2.thrift.http.port"))
            && !(connParams.getPort() > 0)) {
          connParams.setPort(Integer.parseInt(matcher.group(2)));
        }
{noformat}


> Improve beeline logging for dynamic service discovery
> -----------------------------------------------------
>
>                 Key: HIVE-12235
>                 URL: https://issues.apache.org/jira/browse/HIVE-12235
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 1.2.1
>            Reporter: Szehon Ho
>            Assignee: Szehon Ho
>         Attachments: HIVE-12235.2.patch, HIVE-12235.patch
>
>
> It maybe nice to see which host it tried to, and ended up, connecting to.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to