[
https://issues.apache.org/jira/browse/HIVE-26280?focusedWorklogId=780343&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-780343
]
ASF GitHub Bot logged work on HIVE-26280:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/22 15:20
Start Date: 10/Jun/22 15:20
Worklog Time Spent: 10m
Work Description: deniskuzZ commented on code in PR #3340:
URL: https://github.com/apache/hive/pull/3340#discussion_r894641542
##########
metastore/scripts/upgrade/hive/hive-schema-4.0.0-alpha-2.hive.sql:
##########
@@ -1138,6 +1144,9 @@ CREATE EXTERNAL TABLE IF NOT EXISTS
`COMPLETED_COMPACTIONS` (
`CC_HIGHEST_WRITE_ID` bigint,
`CC_HADOOP_JOB_ID` string,
`CC_ERROR_MESSAGE` string,
+ `CC_NEXT_TXN_ID` bigint,
Review Comment:
Cleaner shouldn't pick anything up if there is an open txn < NEXT_TXN_ID.
A downside could be an extra storage (minor) and transformation of
COMPLETED_COMPACTIONS into a swamp. I can't think on how CC_NEXT_TXN_ID &
CC_TXN_ID might be helpful for troubleshooting.
`NEXT_TXN_ID will tell you when the cleaner should have picked up the
compaction for cleaning` - I think this information is only relevant to the
Cleaner and doesn't give any value post-cleanup.
If you still think it could be useful, that's ok we could keep them.
Issue Time Tracking
-------------------
Worklog Id: (was: 780343)
Time Spent: 1.5h (was: 1h 20m)
> Copy more data into COMPLETED_COMPACTIONS for better supportability
> -------------------------------------------------------------------
>
> Key: HIVE-26280
> URL: https://issues.apache.org/jira/browse/HIVE-26280
> Project: Hive
> Issue Type: Improvement
> Components: Transactions
> Reporter: Karen Coppage
> Assignee: Karen Coppage
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> There is some information in COMPACTION_QUEUE that doesn't get copied over to
> COMPLETED_COMPACTIONS when compaction completes. It would help with
> supportability if COMPLETED_COMPACTIONS (and especially the view of it in the
> SYS database) also contained this information.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
