[
https://issues.apache.org/jira/browse/HIVE-26217?focusedWorklogId=777304&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777304
]
ASF GitHub Bot logged work on HIVE-26217:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jun/22 07:02
Start Date: 02/Jun/22 07:02
Worklog Time Spent: 10m
Work Description: SourabhBadhya commented on code in PR #3281:
URL: https://github.com/apache/hive/pull/3281#discussion_r887627260
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -7940,6 +7970,46 @@ protected Operator genFileSinkPlan(String dest, QB qb,
Operator input)
return output;
}
+ private Path getCTASDestinationTableLocation(CreateTableDesc tblDesc,
boolean enableSuffixing) throws SemanticException {
+ Path location;
+ String suffix = "";
+ try {
+ // When location is specified, suffix is not added
+ if (tblDesc.getLocation() == null) {
Review Comment:
Location check happens now at the point where suffixing is decided. Updated.
https://github.com/apache/hive/pull/3281/files#diff-d4b1a32bbbd9e283893a6b52854c7aeb3e356a1ba1add2c4107e52901ca268f9R7616-R7618
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -7940,6 +7970,46 @@ protected Operator genFileSinkPlan(String dest, QB qb,
Operator input)
return output;
}
+ private Path getCTASDestinationTableLocation(CreateTableDesc tblDesc,
boolean enableSuffixing) throws SemanticException {
Review Comment:
Updated.
Issue Time Tracking
-------------------
Worklog Id: (was: 777304)
Time Spent: 12h (was: 11h 50m)
> Make CTAS use Direct Insert Semantics
> -------------------------------------
>
> Key: HIVE-26217
> URL: https://issues.apache.org/jira/browse/HIVE-26217
> Project: Hive
> Issue Type: Improvement
> Reporter: Sourabh Badhya
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 12h
> Remaining Estimate: 0h
>
> CTAS on transactional tables currently does a copy from staging location to
> table location. This can be avoided by using Direct Insert semantics. Added
> support for suffixed table locations as well.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
