[jira] [Work logged] (HIVE-21160) Rewrite Update statement as Multi-insert and do Update split early

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/HIVE-21160?focusedWorklogId=777254&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777254
 ]

ASF GitHub Bot logged work on HIVE-21160:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Jun/22 02:32
            Start Date: 02/Jun/22 02:32
    Worklog Time Spent: 10m 
      Work Description: kasakrisz commented on code in PR #2855:
URL: https://github.com/apache/hive/pull/2855#discussion_r887446340


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/MergeSemanticAnalyzer.java:
##########
@@ -470,8 +405,7 @@ private String handleUpdate(ASTNode 
whenMatchedUpdateClause, StringBuilder rewri
       rewrittenQueryStr.append(" AND 
NOT(").append(deleteExtraPredicate).append(")");
     }
     if(!splitUpdateEarly) {
-      rewrittenQueryStr.append("\n SORT BY ");
-      rewrittenQueryStr.append(targetName).append(".ROW__ID ");
+      appendSortBy(rewrittenQueryStr, Collections.singletonList(targetName + 
".ROW__ID "));
     }
     rewrittenQueryStr.append("\n");

Review Comment:
   Added logging rewritten AST in RewriteSA before passing it to super.analyze.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 777254)
    Time Spent: 3h 10m  (was: 3h)

> Rewrite Update statement as Multi-insert and do Update split early
> ------------------------------------------------------------------
>
>                 Key: HIVE-21160
>                 URL: https://issues.apache.org/jira/browse/HIVE-21160
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Transactions
>    Affects Versions: 3.0.0
>            Reporter: Eugene Koifman
>            Assignee: Krisztian Kasa
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)