[ 
https://issues.apache.org/jira/browse/HIVE-26282?focusedWorklogId=776871&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-776871
 ]

ASF GitHub Bot logged work on HIVE-26282:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jun/22 13:43
            Start Date: 01/Jun/22 13:43
    Worklog Time Spent: 10m 
      Work Description: pvary commented on code in PR #3337:
URL: https://github.com/apache/hive/pull/3337#discussion_r886824007


##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveSchemaConverter.java:
##########
@@ -83,8 +83,9 @@ Type convertType(TypeInfo typeInfo) {
             return Types.BooleanType.get();
           case BYTE:
           case SHORT:
-            Preconditions.checkArgument(autoConvert, "Unsupported Hive type: 
%s, use integer instead",
-                ((PrimitiveTypeInfo) typeInfo).getPrimitiveCategory());
+            Preconditions.checkArgument(autoConvert, "Unsupported Hive type: 
%s, use integer " +

Review Comment:
   `Unsupported Hive type: %s, use integer instead or enable automatic type 
conversion, set 'iceberg.mr.schema.auto.conversion' to true`?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 776871)
    Time Spent: 0.5h  (was: 20m)

> Improve iceberg CTAS error message for unsupported types
> --------------------------------------------------------
>
>                 Key: HIVE-26282
>                 URL: https://issues.apache.org/jira/browse/HIVE-26282
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When running a CTAS query using a hive table that has a tinyint, smallint, 
> varchar or char column it fails with an "Unsupported Hive type" error 
> message. This can be worked around if the  
> 'iceberg.mr.schema.auto.conversion' property is set to true on session level. 
> We should communicate this possibility when raising the exception. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to