[ https://issues.apache.org/jira/browse/HIVE-25907?focusedWorklogId=776099&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-776099 ]
ASF GitHub Bot logged work on HIVE-25907: ----------------------------------------- Author: ASF GitHub Bot Created on: 31/May/22 05:30 Start Date: 31/May/22 05:30 Worklog Time Spent: 10m Work Description: pvary commented on code in PR #2978: URL: https://github.com/apache/hive/pull/2978#discussion_r885216004 ########## ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: ########## @@ -1681,6 +1681,9 @@ boolean doPhase1(ASTNode ast, QB qb, Phase1Ctx ctx_1, PlannerContext plannerCtx) && ch.getChild(0) instanceof ASTNode) { ch = (ASTNode) ch.getChild(0); isTmpFileDest = ch.getToken().getType() == HiveParser.TOK_TMP_FILE; + if (ch.getToken().getType() == HiveParser.StringLiteral) { Review Comment: Then, I think this should be an assert. Issue Time Tracking ------------------- Worklog Id: (was: 776099) Time Spent: 3h 10m (was: 3h) > IOW Directory queries fails to write data to final path when query result > cache is enabled > ------------------------------------------------------------------------------------------ > > Key: HIVE-25907 > URL: https://issues.apache.org/jira/browse/HIVE-25907 > Project: Hive > Issue Type: Bug > Components: Hive > Affects Versions: 4.0.0 > Reporter: Syed Shameerur Rahman > Assignee: Syed Shameerur Rahman > Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > INSERT OVERWRITE DIRECTORY queries fails to write the data to the specified > directory location when query result cache is enabled. > *Steps to reproduce* > {code:java} > 1. create a data file with the following data > 1 abc 10.5 > 2 def 11.5 > 2. create table pointing to that data > create external table iowd(strct struct<a:int, b:string, c:string>) > row format delimited > fields terminated by '\t' > collection items terminated by ' ' > location '<data_location>'; > 3. run the following query > set hive.query.results.cache.enabled=true; > INSERT OVERWRITE DIRECTORY "<destination directory>" SELECT * FROM iowd; > {code} > After execution of the above query, It is expected that the destination > directory contains data from the table iowd, But due to HIVE-21386 it is not > happening anymore. -- This message was sent by Atlassian Jira (v8.20.7#820007)