[
https://issues.apache.org/jira/browse/HIVE-26180?focusedWorklogId=763060&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-763060
]
ASF GitHub Bot logged work on HIVE-26180:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Apr/22 17:25
Start Date: 27/Apr/22 17:25
Worklog Time Spent: 10m
Work Description: zabetak commented on code in PR #3250:
URL: https://github.com/apache/hive/pull/3250#discussion_r860067577
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/dataconnector/jdbc/MySQLConnectorProvider.java:
##########
@@ -31,7 +31,7 @@
public class MySQLConnectorProvider extends AbstractJDBCConnectorProvider {
private static Logger LOG =
LoggerFactory.getLogger(MySQLConnectorProvider.class);
- private static final String DRIVER_CLASS = "org.mariadb.jdbc.Driver";
+ private static final String DRIVER_CLASS = "com.mysql.jdbc.Driver";
Review Comment:
I am not sure why HIVE-25423 changed the driver to use mariadb but maybe it
has to do with the fact that the added test (dataconnector_mysql.q) was also
using a docker image of MariaDB (even though the respective class was implying
that it was MySQL) before I fix it on HIVE-25594.
Issue Time Tracking
-------------------
Worklog Id: (was: 763060)
Time Spent: 1h 10m (was: 1h)
> Change MySQLConnectorProvider driver from mariadb to mysql
> ----------------------------------------------------------
>
> Key: HIVE-26180
> URL: https://issues.apache.org/jira/browse/HIVE-26180
> Project: Hive
> Issue Type: Bug
> Components: StorageHandler
> Affects Versions: 4.0.0-alpha-1, 4.0.0-alpha-2
> Reporter: zhangbutao
> Assignee: zhangbutao
> Priority: Major
> Labels: pull-request-available
> Fix For: 4.0.0-alpha-2
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> I test with example {_}dataconnector_mysql.q{_}. When I execute _show
> tables_ from remote database, it failed with WARN log:
>
> {code:java}
> 2022-04-27T16:52:34,696 WARN [Metastore-Handler-Pool: Thread-48]
> jdbc.AbstractJDBCConnectorProvider: Driver class not found in
> classpath:org.mariadb.jdbc.Driver
> 2022-04-27T16:52:34,698 WARN [Metastore-Handler-Pool: Thread-48]
> metastore.HMSHandler: Unexpected exception while getting table(s) in remote
> database db_mysql
> org.apache.hadoop.hive.metastore.api.MetaException: Could not instantiate a
> provider for database db_mysql{code}
>
> And so I add _mariadb-java-client-2.5.0.jar_ to hive lib, It is ok to show
> tables from remote database, but this leads to failure on native database:
> {code:java}
> 2022-04-27T17:01:38,763 ERROR [Metastore-Handler-Pool: Thread-43]
> Datastore.Schema: An exception was thrown while adding/validating class(es) :
> Table "columns_v2" has been specified with a primary-key to include column
> "CD_ID" but this column is not found in the table. Please check your
> <primary-key> column specification.
> Table "columns_v2" has been specified with a primary-key to include column
> "CD_ID" but this column is not found in the table. Please check your
> <primary-key> column specification.
> org.datanucleus.exceptions.NucleusUserException: Table "columns_v2" has been
> specified with a primary-key to include column "CD_ID" but this column is not
> found in the table. Please check your <primary-key> column specification.
> at
> org.datanucleus.store.rdbms.table.ElementContainerTable.applyUserPrimaryKeySpecification(ElementContainerTable.java:225)
> at
> org.datanucleus.store.rdbms.table.CollectionTable.initialize(CollectionTable.java:235)
> at
> org.datanucleus.store.rdbms.RDBMSStoreManager$ClassAdder.initializeClassTables(RDBMSStoreManager.java:3318)
> at
> org.datanucleus.store.rdbms.RDBMSStoreManager$ClassAdder.run(RDBMSStoreManager.java:2938)
> at
> org.datanucleus.store.rdbms.AbstractSchemaTransaction.execute(AbstractSchemaTransaction.java:118)
> {code}
>
> If I change MySQLConnectorProvider driver from mariadb to mysql, It's good
> to both remote mysql database and native database.
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
