[ https://issues.apache.org/jira/browse/HIVE-26117?focusedWorklogId=755979&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-755979 ]
ASF GitHub Bot logged work on HIVE-26117: ----------------------------------------- Author: ASF GitHub Bot Created on: 12/Apr/22 19:20 Start Date: 12/Apr/22 19:20 Worklog Time Spent: 10m Work Description: scarlin-cloudera commented on code in PR #3179: URL: https://github.com/apache/hive/pull/3179#discussion_r848792227 ########## ql/src/test/results/clientnegative/joinneg.q.out: ########## @@ -1 +1 @@ -FAILED: SemanticException [Error 10004]: Line 6:12 Invalid table alias or column reference 'b': (possible column names are: x.key, x.value, y.key, y.value) +FAILED: SemanticException [Error 10009]: Line 6:12 Invalid table alias 'b' Review Comment: Agreed, but I think that's an issue for the new code. I would rather remove the lines of code that converts to ExprNodes (but keep the unparsetranslator part. Issue Time Tracking ------------------- Worklog Id: (was: 755979) Time Spent: 40m (was: 0.5h) > Remove 2 superfluous lines of code in genJoinRelNode > ---------------------------------------------------- > > Key: HIVE-26117 > URL: https://issues.apache.org/jira/browse/HIVE-26117 > Project: Hive > Issue Type: Bug > Components: CBO > Reporter: Steve Carlin > Assignee: Steve Carlin > Priority: Minor > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > The code was rewritten to associate ASTNodes to RexNodes. Some code was left > behind that doesn't add any value. -- This message was sent by Atlassian Jira (v8.20.1#820001)