[
https://issues.apache.org/jira/browse/HIVE-21456?focusedWorklogId=754681&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-754681
]
ASF GitHub Bot logged work on HIVE-21456:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/22 16:05
Start Date: 08/Apr/22 16:05
Worklog Time Spent: 10m
Work Description: saihemanth-cloudera commented on code in PR #3105:
URL: https://github.com/apache/hive/pull/3105#discussion_r846281556
##########
itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestSSL.java:
##########
@@ -437,15 +439,36 @@ public void testConnectionWrongCertCN() throws Exception {
* Test HMS server with SSL
* @throws Exception
*/
+ @Ignore
@Test
public void testMetastoreWithSSL() throws Exception {
testSSLHMS(true);
}
+ /**
+ * Test HMS server with Http + SSL
+ * @throws Exception
+ */
+ @Test
+ public void testMetastoreWithHttps() throws Exception {
+ // MetastoreConf.setBoolVar(conf,
MetastoreConf.ConfVars.EVENT_DB_NOTIFICATION_API_AUTH, false);
+ //MetastoreConf.setVar(conf,
MetastoreConf.ConfVars.METASTORE_CLIENT_TRANSPORT_MODE, "http");
+ SSLTestUtils.setMetastoreHttpsConf(conf);
+ MetastoreConf.setVar(conf,
MetastoreConf.ConfVars.SSL_TRUSTMANAGERFACTORY_ALGORITHM,
+ KEY_MANAGER_FACTORY_ALGORITHM);
+ MetastoreConf.setVar(conf, MetastoreConf.ConfVars.SSL_TRUSTSTORE_TYPE,
KEY_STORE_TRUST_STORE_TYPE);
+ MetastoreConf.setVar(conf, MetastoreConf.ConfVars.SSL_KEYSTORE_TYPE,
KEY_STORE_TRUST_STORE_TYPE);
+ MetastoreConf.setVar(conf,
MetastoreConf.ConfVars.SSL_KEYMANAGERFACTORY_ALGORITHM,
+ KEY_MANAGER_FACTORY_ALGORITHM);
+
+ testSSLHMS(false);
Review Comment:
Why are we passing false here? This value is used in testSSLHMS()#L459-461
to set the keystore for HMS and HS2. You are already setting this for HMS in
L461 here and we don't need to set for HS2. So why don't we just pass the value
true?
Issue Time Tracking
-------------------
Worklog Id: (was: 754681)
Time Spent: 3.5h (was: 3h 20m)
> Hive Metastore Thrift over HTTP
> -------------------------------
>
> Key: HIVE-21456
> URL: https://issues.apache.org/jira/browse/HIVE-21456
> Project: Hive
> Issue Type: New Feature
> Components: Metastore, Standalone Metastore
> Reporter: Amit Khanna
> Assignee: Sourabh Goyal
> Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-21456.2.patch, HIVE-21456.3.patch,
> HIVE-21456.4.patch, HIVE-21456.patch
>
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> Hive Metastore currently doesn't have support for HTTP transport because of
> which it is not possible to access it via Knox. Adding support for Thrift
> over HTTP transport will allow the clients to access via Knox
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
