[
https://issues.apache.org/jira/browse/HIVE-26116?focusedWorklogId=752967&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752967
]
ASF GitHub Bot logged work on HIVE-26116:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Apr/22 16:00
Start Date: 05/Apr/22 16:00
Worklog Time Spent: 10m
Work Description: klcopp commented on code in PR #3177:
URL: https://github.com/apache/hive/pull/3177#discussion_r842981037
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java:
##########
@@ -320,10 +320,19 @@ private boolean
foundCurrentOrFailedCompactions(ShowCompactResponse compactions,
if (compactions.getCompacts() == null) {
return false;
}
+
+ //In case of an aborted Dynamic partition insert, the created entry in the
compaction queue does not contain
+ //a partition name even for partitioned tables. As a result it can happen
that the ShowCompactResponse contains
+ //an element without partition name for partitioned tables. Therefore, it
is necessary to check the partition name of
Review Comment:
I have to say I got confused here. For people like me this would be better:
> Therefore, it is necessary to check
we could have:
> Therefore, it is necessary to null check
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java:
##########
@@ -320,10 +320,19 @@ private boolean
foundCurrentOrFailedCompactions(ShowCompactResponse compactions,
if (compactions.getCompacts() == null) {
return false;
}
+
+ //In case of an aborted Dynamic partition insert, the created entry in the
compaction queue does not contain
+ //a partition name even for partitioned tables. As a result it can happen
that the ShowCompactResponse contains
+ //an element without partition name for partitioned tables. Therefore, it
is necessary to check the partition name of
Review Comment:
I have to say I got confused here. For people like me this would be better:
> Therefore, it is necessary to check
we could have:
> Therefore, it is necessary to null check
Issue Time Tracking
-------------------
Worklog Id: (was: 752967)
Time Spent: 0.5h (was: 20m)
> Fix handling of compaction requests originating from aborted dynamic
> partition queries in Initiator
> ---------------------------------------------------------------------------------------------------
>
> Key: HIVE-26116
> URL: https://issues.apache.org/jira/browse/HIVE-26116
> Project: Hive
> Issue Type: Bug
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Compaction requests originated from an abort of a dynamic partition insert
> can cause a NPE in Initiator.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
