[
https://issues.apache.org/jira/browse/HIVE-26102?focusedWorklogId=751482&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751482
]
ASF GitHub Bot logged work on HIVE-26102:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/22 09:36
Start Date: 01/Apr/22 09:36
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #3131:
URL: https://github.com/apache/hive/pull/3131#discussion_r840409327
##########
File path:
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java
##########
@@ -261,6 +268,13 @@ public boolean nextKeyValue() throws IOException {
while (true) {
if (currentIterator.hasNext()) {
current = currentIterator.next();
+ Configuration conf = context.getConfiguration();
+ if (HiveIcebergStorageHandler.isDelete(conf,
conf.get(Catalogs.NAME))) {
+ if (current instanceof GenericRecord) {
+ PositionDeleteInfo pdi =
IcebergAcidUtil.parsePositionDeleteInfoFromRecord((GenericRecord) current);
+ PositionDeleteInfo.serializeIntoConf(conf, pdi);
Review comment:
Mostly because the row_position changes for every record. If the record
reader has multiple tasks (i.e. reading multiple files), then the file_path or
even the spec_id/partition_struct could change too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 751482)
Time Spent: 1h 10m (was: 1h)
> Implement DELETE statements for Iceberg tables
> ----------------------------------------------
>
> Key: HIVE-26102
> URL: https://issues.apache.org/jira/browse/HIVE-26102
> Project: Hive
> Issue Type: New Feature
> Reporter: Marton Bod
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
