[
https://issues.apache.org/jira/browse/HIVE-26061?focusedWorklogId=747794&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747794
]
ASF GitHub Bot logged work on HIVE-26061:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/22 13:44
Start Date: 25/Mar/22 13:44
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #3129:
URL: https://github.com/apache/hive/pull/3129#discussion_r835283057
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java
##########
@@ -304,6 +304,10 @@ public static HiveStorageHandler getStorageHandler(
}
}
+ public static String getDefaultComment(HiveStorageHandler storageHandler) {
+ return storageHandler != null ? storageHandler.getDefaultColumnComment() :
HiveStorageHandler.FROM_SERIALIZER;
Review comment:
Default storage handler still could have a `from deserializer` field.
For example AVRO files can contain the schema and they can dictate the columns
of the table. This change makes sure that we do not get an error when the
storage handler is null. The other default is handled by the default
implementation for the `getDefaultColumnComment()` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 747794)
Time Spent: 1h (was: 50m)
> Do not add 'from deserializer' comment upon alter commands for Iceberg tables
> -----------------------------------------------------------------------------
>
> Key: HIVE-26061
> URL: https://issues.apache.org/jira/browse/HIVE-26061
> Project: Hive
> Issue Type: Bug
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently an ALTER TABLE command for Iceberg tables adds the 'from
> deserializer' comment to all columns which do not already have a comment.
> This becomes annoying when issueing REPLACE COLUMNS operations, where you
> have to write out all these superflous comments.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
