[
https://issues.apache.org/jira/browse/HIVE-26069?focusedWorklogId=747772&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747772
]
ASF GitHub Bot logged work on HIVE-26069:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/22 12:57
Start Date: 25/Mar/22 12:57
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #3139:
URL: https://github.com/apache/hive/pull/3139#discussion_r835245082
##########
File path:
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/dbinstall/rules/Derby.java
##########
@@ -88,7 +88,7 @@ public String getInitialJdbcUrl(String hostAddress) {
}
public String getDb() {
- return MetaStoreServerUtils.JUNIT_DATABASE_PREFIX;
+ return "${test.tmp.dir}/" + MetaStoreServerUtils.JUNIT_DATABASE_PREFIX;
Review comment:
We already use the prefix for the in memory datastore in multiple places:
https://github.com/apache/hive/blob/2524c2137bc2e70bd32e43a49a15fbfc0fa93159/standalone-metastore/metastore-server/pom.xml#L395
https://github.com/apache/hive/blob/2524c2137bc2e70bd32e43a49a15fbfc0fa93159/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreFactoryForTests.java#L90-L92
https://github.com/apache/hive/blob/2524c2137bc2e70bd32e43a49a15fbfc0fa93159/standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/utils/TestMetaStoreServerUtils.java#L841-L842
I am not saying that this is good, I just state that we already use this
several times already 😄.
Had to remove this change anyway, since the test failures for
`TestMiniLlapLocalCliDriver`, `TestCliDriver`, ... are caused by this and the
fix is not straightforward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 747772)
Time Spent: 20m (was: 10m)
> Remove unnecessary items from the .gitignore
> --------------------------------------------
>
> Key: HIVE-26069
> URL: https://issues.apache.org/jira/browse/HIVE-26069
> Project: Hive
> Issue Type: Task
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently .gitignore contains files which are generated by test and either
> should be removed by those given test or preferably they should be created
> under the target directories.
> Some of the that we have seen are:
> - metastore_db
> - derby.log
> - datanucleus.log
> Also it might worth to explore why the following directories are not showing
> up in the {{git status}}:
> - streaming/${test.tmp.dir}
> - itests/hive-unit/cmroot
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
