[
https://issues.apache.org/jira/browse/HIVE-26070?focusedWorklogId=747755&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747755
]
ASF GitHub Bot logged work on HIVE-26070:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/22 12:02
Start Date: 25/Mar/22 12:02
Worklog Time Spent: 10m
Work Description: zabetak commented on a change in pull request #3141:
URL: https://github.com/apache/hive/pull/3141#discussion_r835206474
##########
File path: packaging/src/main/assembly/src.xml
##########
@@ -41,6 +41,12 @@
<exclude>**/.project</exclude>
<exclude>**/.settings/**</exclude>
<exclude>**/thirdparty/**</exclude>
+
<exclude>standalone-metastore/metastore-common/src/gen/version/**</exclude>
+ <exclude>standalone-metastore/metastore-server/src/gen/**</exclude>
Review comment:
Can the `gen` be generalized or is it risky?
##########
File path: packaging/src/main/assembly/src.xml
##########
@@ -41,6 +41,12 @@
<exclude>**/.project</exclude>
<exclude>**/.settings/**</exclude>
<exclude>**/thirdparty/**</exclude>
+
<exclude>standalone-metastore/metastore-common/src/gen/version/**</exclude>
+ <exclude>standalone-metastore/metastore-server/src/gen/**</exclude>
+ <exclude>common/src/gen/**</exclude>
+ <exclude>kafka-handler/src/test/gen/**</exclude>
+ <exclude>conf/hive-default.xml.template</exclude>
Review comment:
Can the `hive-default.xml.template` be generalized or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 747755)
Time Spent: 20m (was: 10m)
> Remove the generated files from the source tarball
> --------------------------------------------------
>
> Key: HIVE-26070
> URL: https://issues.apache.org/jira/browse/HIVE-26070
> Project: Hive
> Issue Type: Task
> Reporter: Peter Vary
> Assignee: Peter Vary
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We should discuss and decide if we would like to share the generated files in
> the source tarball.
> There are 3 kind of generated files:
> # Thrift - we keep them in git too, so I would vote for keeping them
> # package-info.java files:
> ** standalone-metastore/metastore-common/src/gen/version
> ** standalone-metastore/metastore-server/src/gen/version
> ** common/src/gen
> # Test Record generated for Kafka tests: kafka-handler/src/test/gen
> I would vote for keeping 1, but remove 2 and 3 from the source tarball
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
