[
https://issues.apache.org/jira/browse/HIVE-26026?focusedWorklogId=747720&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-747720
]
ASF GitHub Bot logged work on HIVE-26026:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/22 10:46
Start Date: 25/Mar/22 10:46
Worklog Time Spent: 10m
Work Description: klcopp commented on a change in pull request #3126:
URL: https://github.com/apache/hive/pull/3126#discussion_r835155164
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java
##########
@@ -442,31 +439,24 @@ protected Boolean findNextCompactionAndExecute(boolean
collectGenericStats, bool
// Don't start compaction or cleaning if not necessary
if (isDynPartAbort(t, ci)) {
- msc.markCompacted(CompactionInfo.compactionInfoToStruct(ci));
+ markWithState(ci, null, CompactionState.Compacted);
compactionTxn.wasSuccessful();
return false;
}
AcidDirectory dir = getAcidStateForWorker(ci, sd, tblValidWriteIds);
if (!isEnoughToCompact(ci.isMajorCompaction(), dir, sd)) {
if (needsCleaning(dir, sd)) {
- msc.markCompacted(CompactionInfo.compactionInfoToStruct(ci));
+ markWithState(ci, null, CompactionState.Compacted);
} else {
- // do nothing
- msc.markCleaned(CompactionInfo.compactionInfoToStruct(ci));
+ markWithState(ci, "None of the compaction thresholds hit, compaction
request is refused!", CompactionState.Refused);
Review comment:
Well, ATTEMPTED is now called DID NOT INITIATE so I'm not sure it makes
sense in this case. Also compaction isn't supported by hive in this case, and
it doesn't make sense to retry (until more deltas are added).
But also I see your point that it's not an error/unsuccessful per se...
(REFUSED compactions are represented in the "ratio of unsuccessful compactions"
metric) ... so I'm not sure what ideal behavior should be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 747720)
Time Spent: 6h 20m (was: 6h 10m)
> Use the new "REFUSED" compaction state where it makes sense
> -----------------------------------------------------------
>
> Key: HIVE-26026
> URL: https://issues.apache.org/jira/browse/HIVE-26026
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> The
> org.apache.hadoop.hive.ql.txn.compactor.Worker#findNextCompactionAndExecute
> method does several checks (The table/partition exists, is not sorted, there
> are enough files to compact, etc.) before it actually executes the compaction
> request. If the compaction request fails on any of these checks, it is put to
> "SUCCEEDED" state which is often misleading for users. SHOW COMPACTIONS will
> show these requests as succeeded without an error, while the table is not
> compacted at all.
> For these cases, the state should be "REFUSED" instead of "SUCCEEDED" among
> with the appropriate error message.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
