[ https://issues.apache.org/jira/browse/HIVE-21456?focusedWorklogId=746034&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-746034 ]
ASF GitHub Bot logged work on HIVE-21456: ----------------------------------------- Author: ASF GitHub Bot Created on: 22/Mar/22 18:47 Start Date: 22/Mar/22 18:47 Worklog Time Spent: 10m Work Description: sourabh912 commented on a change in pull request #3105: URL: https://github.com/apache/hive/pull/3105#discussion_r832508524 ########## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java ########## @@ -1356,6 +1356,13 @@ public static ConfVars getMetaConf(String name) { "Comma-separated list of tasks that will be started in separate threads. These will be" + " started only when the metastore is running as a separate service. They must " + "implement " + METASTORE_TASK_THREAD_CLASS), + THRIFT_TRANSPORT_MODE("metastore.server.thrift.transport.mode", + "hive.metastore.server.thrift.transport.mode", "binary", + "Transport mode for thrift server in Metastore. Can be binary or http"), + THRIFT_HTTP_PATH("metastore.server.thrift.http.path", Review comment: I think a better config name would be `metastore.server.thrift.transport.http.path`. Thoughts? ########## File path: standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/SecurityUtils.java ########## @@ -271,6 +286,31 @@ public static TTransport getSSLSocket(String host, int port, int loginTimeout, return getSSLSocketWithHttps(tSSLSocket); } + public static THttpClient getHttpSSLSocket(String httpsUrl, String trustStorePath, + String trustStorePasswd, String trustStoreAlgorithm, String trustStoreType) Review comment: The server side code for this is in HiveMetaStore.java at https://github.com/apache/hive/pull/3105/files#diff-00e70b6958060aa36762b21bf16676f83af01c1e09b56816aecc6abe7c8ac866R683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 746034) Time Spent: 1h 40m (was: 1.5h) > Hive Metastore HTTP Thrift > -------------------------- > > Key: HIVE-21456 > URL: https://issues.apache.org/jira/browse/HIVE-21456 > Project: Hive > Issue Type: New Feature > Components: Metastore, Standalone Metastore > Reporter: Amit Khanna > Assignee: Sourabh Goyal > Priority: Major > Labels: pull-request-available > Attachments: HIVE-21456.2.patch, HIVE-21456.3.patch, > HIVE-21456.4.patch, HIVE-21456.patch > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Hive Metastore currently doesn't have support for HTTP transport because of > which it is not possible to access it via Knox. Adding support for Thrift > over HTTP transport will allow the clients to access via Knox -- This message was sent by Atlassian Jira (v8.20.1#820001)