[
https://issues.apache.org/jira/browse/HIVE-26026?focusedWorklogId=745680&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-745680
]
ASF GitHub Bot logged work on HIVE-26026:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Mar/22 09:34
Start Date: 22/Mar/22 09:34
Worklog Time Spent: 10m
Work Description: veghlaci05 opened a new pull request #3126:
URL: https://github.com/apache/hive/pull/3126
### What changes were proposed in this pull request?
When the pre-compaction checks fail in Worker, the compaction state should
be set to "REFUSED" instead of "SUCCEEDED" among with the appropriate error
message.
### Why are the changes needed?
The
org.apache.hadoop.hive.ql.txn.compactor.Worker#findNextCompactionAndExecute
method does several checks (The table/partition exists, is not sorted, there
are enough files to compact, etc.) before it actually executes the compaction
request. If the compaction request fails on any of these checks, it is put to
"SUCCEEDED" state which is often misleading for users. SHOW COMPACTIONS will
show these requests as succeeded without an error, while the table is not
compacted at all.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manually and through unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 745680)
Remaining Estimate: 0h
Time Spent: 10m
> Use the new "REFUSED" compaction state where it makes sense
> -----------------------------------------------------------
>
> Key: HIVE-26026
> URL: https://issues.apache.org/jira/browse/HIVE-26026
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Reporter: László Végh
> Assignee: László Végh
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The
> org.apache.hadoop.hive.ql.txn.compactor.Worker#findNextCompactionAndExecute
> method does several checks (The table/partition exists, is not sorted, there
> are enough files to compact, etc.) before it actually executes the compaction
> request. If the compaction request fails on any of these checks, it is put to
> "SUCCEEDED" state which is often misleading for users. SHOW COMPACTIONS will
> show these requests as succeeded without an error, while the table is not
> compacted at all.
> For these cases, the state should be "REFUSED" instead of "SUCCEEDED" among
> with the appropriate error message.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
