[
https://issues.apache.org/jira/browse/HIVE-25989?focusedWorklogId=738662&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-738662
]
ASF GitHub Bot logged work on HIVE-25989:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/22 10:52
Start Date: 09/Mar/22 10:52
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #3076:
URL: https://github.com/apache/hive/pull/3076#discussion_r822523268
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/info/show/properties/ShowTablePropertiesOperation.java
##########
@@ -67,8 +69,10 @@ public int execute() throws HiveException {
} else {
Map<String, String> properties = new TreeMap<String,
String>(tbl.getParameters());
for (Entry<String, String> entry : properties.entrySet()) {
- ShowUtils.appendNonNull(builder, entry.getKey(), true);
- ShowUtils.appendNonNull(builder, entry.getValue());
+ if (!entry.getKey().equals(TABLE_IS_CTLT)) {
Review comment:
Good question. I think it was just an omission. I'll add that in here too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 738662)
Time Spent: 1.5h (was: 1h 20m)
> CTLT HBaseStorageHandler is dropping underlying HBase table when failed
> -----------------------------------------------------------------------
>
> Key: HIVE-25989
> URL: https://issues.apache.org/jira/browse/HIVE-25989
> Project: Hive
> Issue Type: Bug
> Reporter: Naresh P R
> Assignee: Marton Bod
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> With hive.strict.managed.tables & hive.create.as.acid,
> Hive-Hbase rollback code is assuming it is a createTable failure instead of
> CTLT & removing underlying hbase table while rolling back at here.
> [https://github.com/apache/hive/blob/master/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseMetaHook.java#L187-L195]
>
> Repro
>
> {code:java}
> hbase
> =====
> hbase shell
> create 'hbase_hive_table', 'cf'
> beeline
> =======
> set hive.support.concurrency=true;
> set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
> set hive.strict.managed.tables=true;
> set hive.create.as.acid=true;
> set hive.create.as.insert.only=true;
> set hive.default.fileformat.managed=ORC;
> > CREATE EXTERNAL TABLE `hbase_hive_table`(
> `key` int COMMENT '',
> `value` string COMMENT '')
> ROW FORMAT SERDE
> 'org.apache.hadoop.hive.hbase.HBaseSerDe'
> STORED BY
> 'org.apache.hadoop.hive.hbase.HBaseStorageHandler'
> WITH SERDEPROPERTIES (
> 'hbase.columns.mapping'=':key,cf:cf')
> TBLPROPERTIES ('hbase.table.name'='hbase_hive_table');
> > select * from hbase_hive_table;
> +-----------------------+-------------------------+
> | hbase_hive_table.key | hbase_hive_table.value |
> +-----------------------+-------------------------+
> +-----------------------+-------------------------+
> > create table new_hbase_hive_table like hbase_hive_table;
> Caused by: org.apache.hadoop.hive.metastore.api.MetaException: The table must
> be stored using an ACID compliant format (such as ORC):
> default.new_hbase_hive_table
> > select * from hbase_hive_table;
> Error: java.io.IOException: org.apache.hadoop.hbase.TableNotFoundException:
> hbase_hive_table
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
