[
https://issues.apache.org/jira/browse/HIVE-25645?focusedWorklogId=736690&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-736690
]
ASF GitHub Bot logged work on HIVE-25645:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Mar/22 14:36
Start Date: 04/Mar/22 14:36
Worklog Time Spent: 10m
Work Description: pvary commented on a change in pull request #3079:
URL: https://github.com/apache/hive/pull/3079#discussion_r819622269
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactionQueryBuilder.java
##########
@@ -347,8 +347,16 @@ private void buildWhereClauseForInsert(StringBuilder
query) {
query.append(" where ");
for (int i = 0; i < keys.size(); ++i) {
- query.append(i == 0 ? "`" : " and
`").append(keys.get(i).getName()).append("`='")
- .append(vals.get(i)).append("'");
+ FieldSchema keySchema = keys.get(i);
+ boolean isBooleanKey = keySchema.getType().equalsIgnoreCase("boolean");
+ query.append(i == 0 ? "`" : " and
`").append(keySchema.getName()).append("`=");
+ if (!isBooleanKey) {
Review comment:
nit: Maybe easier to read:
```
if (isBooleanKey) {
query.append("'").append(vals.get(i)).append("'");
} else {
query.append(vals.get(i));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 736690)
Time Spent: 1h (was: 50m)
> Query-based compaction doesn't work when partition column type is boolean
> -------------------------------------------------------------------------
>
> Key: HIVE-25645
> URL: https://issues.apache.org/jira/browse/HIVE-25645
> Project: Hive
> Issue Type: Task
> Reporter: Denys Kuzmenko
> Assignee: László Végh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
