[
https://issues.apache.org/jira/browse/HIVE-25971?focusedWorklogId=732018&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-732018
]
ASF GitHub Bot logged work on HIVE-25971:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/22 00:27
Start Date: 24/Feb/22 00:27
Worklog Time Spent: 10m
Work Description: rbalamohan commented on pull request #3046:
URL: https://github.com/apache/hive/pull/3046#issuecomment-1049360307
Is it because of
https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/util/concurrent/ThreadPoolExecutor.java#L1061
?
{code}
boolean timed = allowCoreThreadTimeOut || wc > corePoolSize;
..
...
...
Runnable r = timed ?
workQueue.poll(keepAliveTime, TimeUnit.NANOSECONDS) :
workQueue.take();
{code}
However, allowCoreThreadTimeOut will be false by default.
So unless someone explicitly sets allowCoreThreadTimeOut(true), this
condition should not happen.
Can you share the logs when you observed 1 minute delay in shutdown?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 732018)
Time Spent: 20m (was: 10m)
> Tez task shutdown getting delayed due to cached thread pool not closed
> ----------------------------------------------------------------------
>
> Key: HIVE-25971
> URL: https://issues.apache.org/jira/browse/HIVE-25971
> Project: Hive
> Issue Type: Improvement
> Components: Tez
> Affects Versions: 2.4.0, 3.1.2
> Reporter: Shailesh Gupta
> Assignee: Shailesh Gupta
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We are using
> a[CachedThreadPool|https://github.com/apache/hive/blob/branch-2.3/ql/src/java/org/apache/hadoop/hive/ql/exec/tez/ObjectCache.java]
> but not closing it. CachedThreadPool creates non daemon threads, causing the
> Tez Task JVM shutdown delayed upto 1 min, as default idle timeout is 1 min.
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
