[
https://issues.apache.org/jira/browse/HIVE-25960?focusedWorklogId=729586&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-729586
]
ASF GitHub Bot logged work on HIVE-25960:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/22 11:07
Start Date: 18/Feb/22 11:07
Worklog Time Spent: 10m
Work Description: abstractdog commented on a change in pull request #3031:
URL: https://github.com/apache/hive/pull/3031#discussion_r809901168
##########
File path: common/src/java/org/apache/hadoop/hive/common/FileUtils.java
##########
@@ -361,7 +361,7 @@ private static void listS3FilesRecursive(FileStatus base,
FileSystem fs, List<Fi
RemoteIterator<LocatedFileStatus> remoteIterator =
fs.listFiles(base.getPath(), true);
while (remoteIterator.hasNext()) {
LocatedFileStatus each = remoteIterator.next();
- Path relativePath = new
Path(each.getPath().toString().replace(base.toString(), ""));
+ Path relativePath = new
Path(each.getPath().toString().replaceFirst(base.getPath().toString(), ""));
Review comment:
change makes sense
some ideas:
1. isn't Path.relativize for the same purpose?
a) is so could you please check its source if it does this optimized version
or not worse (from performance POV)
b) if it isn't, could you please refactor this to utility method here? in
this case, please include unit test into TestFileUtils
##########
File path: common/src/java/org/apache/hadoop/hive/common/FileUtils.java
##########
@@ -361,7 +361,7 @@ private static void listS3FilesRecursive(FileStatus base,
FileSystem fs, List<Fi
RemoteIterator<LocatedFileStatus> remoteIterator =
fs.listFiles(base.getPath(), true);
while (remoteIterator.hasNext()) {
LocatedFileStatus each = remoteIterator.next();
- Path relativePath = new
Path(each.getPath().toString().replace(base.toString(), ""));
+ Path relativePath = new
Path(each.getPath().toString().replaceFirst(base.getPath().toString(), ""));
Review comment:
change makes sense
some ideas:
isn't Path.relativize for the same purpose?
a) is so could you please check its source if it does this optimized version
or not worse (from performance POV)
b) if it isn't, could you please refactor this to utility method here? in
this case, please include unit test into TestFileUtils
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 729586)
Time Spent: 20m (was: 10m)
> Fix S3a recursive listing logic
> -------------------------------
>
> Key: HIVE-25960
> URL: https://issues.apache.org/jira/browse/HIVE-25960
> Project: Hive
> Issue Type: Bug
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> To make the path relative:
> Path relativePath = new
> Path(each.getPath().toString().replace(base.toString(), ""));
>
> Here base in the FileStatus not the path. It should be
> base.getPath().toString() and instead of replace it should be replaceFirst()
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
