[
https://issues.apache.org/jira/browse/HIVE-25747?focusedWorklogId=727651&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-727651
]
ASF GitHub Bot logged work on HIVE-25747:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Feb/22 19:07
Start Date: 15/Feb/22 19:07
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #2881:
URL: https://github.com/apache/hive/pull/2881#discussion_r806937463
##########
File path:
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveTezModelRelMetadataProvider.java
##########
@@ -58,4 +60,24 @@
HiveRelMdPredicates.SOURCE,
JaninoRelMetadataProvider.DEFAULT)));
+ public static JaninoRelMetadataProvider with(RelOptMaterialization
materialization) {
+ return JaninoRelMetadataProvider.of(
+ ChainedRelMetadataProvider.of(
+ ImmutableList.of(
+ HiveRelMdDistinctRowCount.SOURCE,
Review comment:
can't we reuse somehow the other list(`DEFAULT`):
I think something like this could probably work:
```
public static final JaninoRelMetadataProvider DEFAULT2 =
JaninoRelMetadataProvider.of(
ChainedRelMetadataProvider.of(
ImmutableList.of(
HiveRelMdRowCount.SOURCE,
DEFAULT)));
```
this provider could probably also be moved closer to the place where its
being used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 727651)
Time Spent: 1h 10m (was: 1h)
> Make a cost base decision when rebuilding materialized views
> ------------------------------------------------------------
>
> Key: HIVE-25747
> URL: https://issues.apache.org/jira/browse/HIVE-25747
> Project: Hive
> Issue Type: Improvement
> Components: CBO, Materialized views
> Reporter: Krisztian Kasa
> Assignee: Krisztian Kasa
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Choose between full insert-overwrite and partition based incremental rebuild
> plan when rebuilding partitioned materialized views.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
