[ https://issues.apache.org/jira/browse/HIVE-25929?focusedWorklogId=726986&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-726986 ]
ASF GitHub Bot logged work on HIVE-25929: ----------------------------------------- Author: ASF GitHub Bot Created on: 15/Feb/22 12:02 Start Date: 15/Feb/22 12:02 Worklog Time Spent: 10m Work Description: abstractdog commented on pull request #3019: URL: https://github.com/apache/hive/pull/3019#issuecomment-1040191210 > LGTM, left few minor comments, thanks for the patch @abstractdog! Unfortunately I am not a committer so it won't count as +1 for merging, but hope it helps anyway :) thanks @asolimando for the review, it should help with moving this forward -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 726986) Time Spent: 1h (was: 50m) > Let secret config properties to be propagated to Tez > ---------------------------------------------------- > > Key: HIVE-25929 > URL: https://issues.apache.org/jira/browse/HIVE-25929 > Project: Hive > Issue Type: Bug > Reporter: László Bodor > Assignee: László Bodor > Priority: Major > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > History in chronological order: > HIVE-10508: removed some passwords from config that's propagated to execution > engines > HIVE-9013: introduced hive.conf.hidden.list, which is used instead of the > hardcoded list in HIVE-10508 > the problem with HIVE-9013 is it's about to introduce a common method for > removing sensitive data from Configuration, which absolutely makes sense in > most of the cases (set command showing sensitive data), but can cause issues > e.g. while using non-secure cloud connectors on a cluster, where instead of > the hadoop credential provider API (which is considered the secure and proper > way), passwords/secrets appear in the Configuration object (like: > "fs.azure.account.oauth2.client.secret") > 2 possible solutions: > 1. introduce a new property like: "hive.conf.hidden.list.exec.engines" -> > which defaults to "hive.conf.hidden.list" (configurable, but maybe just more > confusing to users, having a new config property which should be understood > and maintained on a cluster) > 2. simply revert DAGUtils to use to old stripHivePasswordDetails introduced > by HIVE-10508 (convenient, less confusing for users, but cannot be configured) -- This message was sent by Atlassian Jira (v8.20.1#820001)